New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the allow_ra sysctl for ipv4 from default systl whitelist #1590
Remove the allow_ra sysctl for ipv4 from default systl whitelist #1590
Conversation
The allow_ra sysctl controlls router advertisment settings which are an ipv6 thing only. As such it should only be present for ipv6.
/assign @yuvalk |
/lgtm |
/approve |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, mmirecki, yuvalk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
which will result in an error when the tuning cni will write to it |
/retest-required |
@mmirecki: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The allow_ra sysctl controlls router advertisment settings which are an ipv6 thing only. As such it should only be present for ipv6.