Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the allow_ra sysctl for ipv4 from default systl whitelist #1590

Conversation

mmirecki
Copy link

The allow_ra sysctl controlls router advertisment settings which are an ipv6 thing only. As such it should only be present for ipv6.

The allow_ra sysctl controlls router advertisment settings which are
an ipv6 thing only. As such it should only be present for ipv6.
@mmirecki
Copy link
Author

/assign @yuvalk

@yuvalk
Copy link
Contributor

yuvalk commented Oct 17, 2022

/lgtm
looks good to me
note, that there's only /proc/sys/net/ipv6/conf/interface/accept_ra so the ipv4 sysctl simply does not exists

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@dcbw
Copy link
Contributor

dcbw commented Oct 17, 2022

/approve

@dcbw
Copy link
Contributor

dcbw commented Oct 17, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mmirecki, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4b2ae73 and 2 for PR HEAD a93c2a7 in total

@mmirecki
Copy link
Author

/retest-required

@mmirecki
Copy link
Author

/lgtm looks good to me note, that there's only /proc/sys/net/ipv6/conf/interface/accept_ra so the ipv4 sysctl simply does not exists

which will result in an error when the tuning cni will write to it

@mmirecki
Copy link
Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7b122b7 and 1 for PR HEAD a93c2a7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@mmirecki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-ipsec-step-registry a93c2a7 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-ovn-serial a93c2a7 link false /test e2e-aws-ovn-serial
ci/prow/e2e-hypershift-ovn a93c2a7 link false /test e2e-hypershift-ovn
ci/prow/e2e-ovn-step-registry a93c2a7 link false /test e2e-ovn-step-registry
ci/prow/e2e-vsphere-ovn-windows a93c2a7 link false /test e2e-vsphere-ovn-windows
ci/prow/e2e-ovn-hybrid-step-registry a93c2a7 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-sdn-upgrade a93c2a7 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-aws-ovn-windows a93c2a7 link false /test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ad77b0b and 0 for PR HEAD a93c2a7 in total

@openshift-merge-robot openshift-merge-robot merged commit d3d67be into openshift:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants