Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4417: Added missing API field podref to OverlappingRangeIPReservation CRD #1677

Merged
merged 1 commit into from Feb 9, 2023
Merged

OCPBUGS-4417: Added missing API field podref to OverlappingRangeIPReservation CRD #1677

merged 1 commit into from Feb 9, 2023

Conversation

nicklesimba
Copy link
Contributor

@nicklesimba nicklesimba commented Jan 12, 2023 •
edited

The OverlappingRangeIPReservation CRD was missing the podref field. Because of this, an issue occurs when the ip-reconciler code from whereabouts get executed, where the ip-reconciler will incorrectly view a pod as not alive, and consequently incorrectly delete the OverlappingRangeIPReservation object from kubernetes.

I updated the CRD to include the podref field.

Signed-off-by: nicklesimba simha.nikhil@gmail.com

@nicklesimba
added missing api field podref
0e81248 
Signed-off-by: nicklesimba <simha.nikhil@gmail.com>
@openshift-ci openshift-ci bot requested review from abhat and dcbw January 12, 2023 17:06
@nicklesimba nicklesimba changed the title [DoNotMerge] WIP added missing api field podref Added missing API field podref to OverlappingRangeIPReservation CRD Jan 12, 2023
@dougbtv
Copy link
Member

dougbtv commented Jan 12, 2023

/lgtm

@dougbtv
Copy link
Member

dougbtv commented Jan 12, 2023

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, nicklesimba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 830daae and 2 for PR HEAD 0e81248 in total

@nicklesimba nicklesimba changed the title Added missing API field podref to OverlappingRangeIPReservation CRD OCPBUGS-4417: Added missing API field podref to OverlappingRangeIPReservation CRD Jan 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

@nicklesimba: This pull request references Jira Issue OCPBUGS-4417, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The OverlappingRangeIPReservation CRD was missing the podref field. Because of this, an issue occurs when the ip-reconciler code from whereabouts get executed, where the ip-reconciler will incorrectly view a pod as not alive, and consequently incorrectly delete the OverlappingRangeIPReservation object from kubernetes.

I updated the CRD to include the podref field.

Signed-off-by: nicklesimba simha.nikhil@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nicklesimba
Copy link
Contributor Author

/retest-required

@nicklesimba
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 17, 2023
@openshift-ci-robot
Copy link
Contributor

@nicklesimba: This pull request references Jira Issue OCPBUGS-4417, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 17, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a718708 and 1 for PR HEAD 0e81248 in total

@dougbtv
Copy link
Member

dougbtv commented Jan 18, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 50fa8db and 0 for PR HEAD 0e81248 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0e81248 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023
@abhat
Copy link
Contributor

abhat commented Jan 19, 2023

/retest-required

1 similar comment
@nicklesimba
Copy link
Contributor Author

/retest-required

@nicklesimba
Copy link
Contributor Author

/test e2e-network-migration

@zshi-redhat
Copy link
Contributor

/retest-required

@nicklesimba
Copy link
Contributor Author

/retest-required

1 similar comment
@nicklesimba
Copy link
Contributor Author

/retest-required

@nicklesimba nicklesimba mentioned this pull request Feb 2, 2023
Closed
@nicklesimba
Copy link
Contributor Author

I made a dummy PR with no changes to see if network-migration job will fail there - to isolate if the failure is due to my PR or not. Waiting on results...

@nicklesimba
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023 •
edited

@nicklesimba: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 0e81248 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-sdn 0e81248 link false /test e2e-openstack-sdn
ci/prow/e2e-hypershift-ovn 0e81248 link false /test e2e-hypershift-ovn
ci/prow/e2e-network-mtu-migration-ovn-ipv4 0e81248 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-network-mtu-migration-ovn-ipv6 0e81248 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-ovn-ipsec-step-registry 0e81248 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-gcp-ovn-upgrade 0e81248 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-ovn 0e81248 link false /test e2e-openstack-ovn
ci/prow/e2e-ovn-hybrid-step-registry 0e81248 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 0e81248 link false /test e2e-metal-ipi-ovn-ipv6-ipsec

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dougbtv
Copy link
Member

dougbtv commented Feb 8, 2023

/override ci/prow/e2e-network-migration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

@dougbtv: Overrode contexts on behalf of dougbtv: ci/prow/e2e-network-migration

In response to this:

/override ci/prow/e2e-network-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv
Copy link
Member

dougbtv commented Feb 8, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d5dca0e and 2 for PR HEAD 0e81248 in total

@openshift-merge-robot openshift-merge-robot merged commit 456b456 into openshift:master Feb 9, 2023
@openshift-ci-robot
Copy link
Contributor

@nicklesimba: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4417 has been moved to the MODIFIED state.

In response to this:

The OverlappingRangeIPReservation CRD was missing the podref field. Because of this, an issue occurs when the ip-reconciler code from whereabouts get executed, where the ip-reconciler will incorrectly view a pod as not alive, and consequently incorrectly delete the OverlappingRangeIPReservation object from kubernetes.

I updated the CRD to include the podref field.

Signed-off-by: nicklesimba simha.nikhil@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 9, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-08-10-021434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@dougbtv dougbtv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicklesimba @dougbtv @openshift-ci-robot @abhat @zshi-redhat @openshift-merge-robot