Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSASINFRA-3075 - sync_vips: allow external LB on OpenStack platform #1678

Closed
wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Member

If the VIPs aren't defined in the PlatformStatus, don't try to sync the
vips, they don't exist.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
Once this PR has been reviewed and has the lgtm label, please assign fepan for approval by writing /assign @fepan in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM EmilienM force-pushed the osp-external-lb branch 3 times, most recently from 7cda3a5 to e499f88 Compare January 12, 2023 21:05
If the VIPs aren't defined in the PlatformStatus, don't try to sync the
vips, they don't exist.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-ovn a521599 link false /test e2e-hypershift-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec a521599 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-ovn-ipsec-step-registry a521599 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-sdn-upgrade a521599 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 a521599 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-network-migration a521599 link true /test e2e-network-migration
ci/prow/e2e-aws-ovn-single-node a521599 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-ovn-windows a521599 link true /test e2e-vsphere-ovn-windows
ci/prow/e2e-network-mtu-migration-ovn-ipv6 a521599 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-openstack-sdn a521599 link false /test e2e-openstack-sdn
ci/prow/e2e-openstack-ovn a521599 link false /test e2e-openstack-ovn
ci/prow/e2e-network-mtu-migration-sdn-ipv4 a521599 link false /test e2e-network-mtu-migration-sdn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM EmilienM changed the title sync_vips: allow external LB on OpenStack platform OSASINFRA-3075- sync_vips: allow external LB on OpenStack platform Jan 18, 2023
@EmilienM EmilienM changed the title OSASINFRA-3075- sync_vips: allow external LB on OpenStack platform OSASINFRA-3075 sync_vips: allow external LB on OpenStack platform Jan 18, 2023
@EmilienM EmilienM changed the title OSASINFRA-3075 sync_vips: allow external LB on OpenStack platform OSASINFRA-3075 - sync_vips: allow external LB on OpenStack platform Jan 18, 2023
@EmilienM
Copy link
Member Author

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2023

@EmilienM: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jan 29, 2023
@EmilienM
Copy link
Member Author

I'm closing it because for now we don't need this one anymore, see openshift/enhancements#1322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant