Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDN-2484] Add support for AdminPolicyBasedExternalRoute CRD and controller's RBAC #1765

Conversation

jordigilh
Copy link
Contributor

Adds the AdminPolicyBasedExternalRoute CRDs and includes the RBAC verbs for controllers.

Requires this PR to be merged before this one goes ahead.

FYI @trozet

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@jordigilh jordigilh changed the title [WIP] Add support for AdminPolicyBasedExternalRoute CRD and controller's RBAC [SDN-2484] [WIP] Add support for AdminPolicyBasedExternalRoute CRD and controller's RBAC Apr 24, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2023
@jordigilh jordigilh force-pushed the sdn_2482_add_admin_policy_based_external_route branch from 6203fac to b09cc92 Compare May 25, 2023 13:58
@jordigilh
Copy link
Contributor Author

/retest

@jordigilh
Copy link
Contributor Author

@trozet PTAL.

@jordigilh jordigilh force-pushed the sdn_2482_add_admin_policy_based_external_route branch from b09cc92 to cce5df4 Compare June 20, 2023 16:08
@jordigilh
Copy link
Contributor Author

/retest

2 similar comments
@jordigilh
Copy link
Contributor Author

/retest

@jordigilh
Copy link
Contributor Author

/retest

@jordigilh jordigilh changed the title [SDN-2484] [WIP] Add support for AdminPolicyBasedExternalRoute CRD and controller's RBAC [SDN-2484] Add support for AdminPolicyBasedExternalRoute CRD and controller's RBAC Jun 21, 2023
@jordigilh
Copy link
Contributor Author

/retest-required

@trozet
Copy link
Contributor

trozet commented Jun 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jordigilh, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@trozet
Copy link
Contributor

trozet commented Jun 21, 2023

gcp-ovn failed because of known bug:

{  pods/openshift-ovn-kubernetes_ovnkube-master-grq48_ovnkube-master_previous.log.gz:E0621 13:23:31.600003       1 runtime.go:79] Observed a panic: &runtime.TypeAssertionError{_interface:(*runtime._type)(0x1dd8820), concrete:(*runtime._type)(0x1f01740), asserted:(*runtime._type)(0x20f42e0), missingMethod:""} (interface conversion: interface {} is cache.DeletedFinalStateUnknown, not *v1.Pod)}

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-gcp-ovn

In response to this:

gcp-ovn failed because of known bug:

{  pods/openshift-ovn-kubernetes_ovnkube-master-grq48_ovnkube-master_previous.log.gz:E0621 13:23:31.600003       1 runtime.go:79] Observed a panic: &runtime.TypeAssertionError{_interface:(*runtime._type)(0x1dd8820), concrete:(*runtime._type)(0x1f01740), asserted:(*runtime._type)(0x20f42e0), missingMethod:""} (interface conversion: interface {} is cache.DeletedFinalStateUnknown, not *v1.Pod)}

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@jordigilh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack cce5df4 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-ovn-serial cce5df4 link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ad6a3fb into openshift:master Jun 21, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants