Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20276: Edited multus-admission-controller deployment config to not add autom… #1767

Conversation

cappetersson
Copy link
Contributor

@cappetersson cappetersson commented Apr 4, 2023

Fix for issue 554

@hasueki
Copy link

hasueki commented Apr 21, 2023

/retest

2 similar comments
@hasueki
Copy link

hasueki commented May 5, 2023

/retest

@hasueki
Copy link

hasueki commented May 25, 2023

/retest

@cappetersson
Copy link
Contributor Author

Hi, @JacobTanenbaum @jcaamano
Are any of you able to see why the PR tests fail for this PR? I'm confused since I'm only adding one line so I'm wondering if there is something I might be missing.
Appreciate the help!

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

@jcaamano
Would you mind giving this a review? Failing tests seems to be related to the version issues for the ci so I just want to make sure my code is correct.
Thanks

@cappetersson
Copy link
Contributor Author

/retest

1 similar comment
@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

@JacobTanenbaum @jcaamano
All tests passing.

@dcbw
Copy link
Contributor

dcbw commented Jul 7, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cappetersson, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3a5af01 and 2 for PR HEAD 6fae35d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 47c5d16 and 1 for PR HEAD 6fae35d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7b9b0c2 and 0 for PR HEAD 6fae35d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

@cappetersson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 22e39ae into openshift:master Jul 10, 2023
31 checks passed
@cappetersson cappetersson deleted the origin/control-plane-master branch July 11, 2023 16:10
@cappetersson
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@cappetersson: new pull request created: #1884

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cappetersson
Copy link
Contributor Author

/cherry-pick release-4.13

@cappetersson
Copy link
Contributor Author

/cherry-pick release-4.14

@cappetersson
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@cappetersson: new pull request created: #1885

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@cappetersson: new pull request could not be created: failed to create pull request against openshift/cluster-network-operator#release-4.14 from head openshift-cherrypick-robot:cherry-pick-1767-to-release-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.14 and openshift-cherrypick-robot:cherry-pick-1767-to-release-4.14"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@cappetersson: new pull request could not be created: failed to create pull request against openshift/cluster-network-operator#release-4.15 from head openshift-cherrypick-robot:cherry-pick-1767-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.15 and openshift-cherrypick-robot:cherry-pick-1767-to-release-4.15"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cappetersson cappetersson changed the title Edited multus-admission-controller deployment config to not add autom… OCPBUGS-20276: Edited multus-admission-controller deployment config to not add autom… Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

@cappetersson: Jira Issue OCPBUGS-20276: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20276 has been moved to the MODIFIED state.

In response to this:

Fix for issue 554

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cappetersson
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cappetersson: Jira Issue OCPBUGS-20276 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cappetersson
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cappetersson: Jira Issue OCPBUGS-20276 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants