Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-networkpolicies support for OVN #1796

Merged
merged 2 commits into from Jun 22, 2023
Merged

Add multi-networkpolicies support for OVN #1796

merged 2 commits into from Jun 22, 2023

Conversation

jcaamano
Copy link
Contributor

No description provided.

@jcaamano
Copy link
Contributor Author

/cc @maiqueb @trozet

@openshift-ci openshift-ci bot requested review from maiqueb, trozet and dcbw April 27, 2023 08:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
maiqueb
maiqueb approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jcaamano
Copy link
Contributor Author

/hold

Will add a flag in OVN-K and enable it form here

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023
@jcaamano
Add multi-networkpolicies to ovn-k rbac
49ca75b 
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano
Propagate UseMultiNetworkPolicies config option to OVN
2b4b734 
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano jcaamano changed the title Add multi-netwrokpolicies to ovn-k rbac Add multi-netwrokpolicies support for OVN Apr 27, 2023
@jcaamano jcaamano changed the title Add multi-netwrokpolicies support for OVN Add multi-networkpolicies support for OVN Apr 27, 2023
@jcaamano
Copy link
Contributor Author

/hold

Depends on ovn-org/ovn-kubernetes#3555

@jcaamano
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@jcaamano
Copy link
Contributor Author

/hold

ooops

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@maiqueb
Copy link
Contributor

maiqueb commented May 17, 2023

@jcaamano what is holding this PR back ?

Anything I can do to help you move this forward ?

@jcaamano
Copy link
Contributor Author

@jcaamano what is holding this PR back ?

Anything I can do to help you move this forward ?

Changes on 4.14 release branch are blocked as far as I am aware.

@maiqueb
Copy link
Contributor

maiqueb commented May 17, 2023

4.14 release branch == main branch (for the time being), right ?

Wasn't aware.

@jcaamano

@jcaamano
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@maiqueb
Copy link
Contributor

maiqueb commented Jun 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@kyrtapz
Copy link
Contributor

kyrtapz commented Jun 20, 2023

/lgtm
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz, maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6467b06 and 2 for PR HEAD 2b4b734 in total

@jcaamano
Copy link
Contributor Author

/retest-required

1 similar comment
@jcaamano
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ad6a3fb and 1 for PR HEAD 2b4b734 in total

@jcaamano
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor Author

e2e-aws-ovn-network-migration is perma failing again so opened a new bug:

https://issues.redhat.com/browse/OCPBUGS-15287

/override ci/prow/e2e-aws-ovn-network-migration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-network-migration

In response to this:

e2e-aws-ovn-network-migration is perma failing again so opened a new bug:

https://issues.redhat.com/browse/OCPBUGS-15287

/override ci/prow/e2e-aws-ovn-network-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023 •
edited

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-sdn-upgrade 2b4b734 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-vsphere-ovn 2b4b734 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack 2b4b734 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-openstack-sdn 2b4b734 link false /test e2e-openstack-sdn
ci/prow/e2e-aws-ovn-single-node 2b4b734 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 93d52a1 into openshift:master Jun 22, 2023
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@trozet trozet Awaiting requested review from trozet

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@kyrtapz kyrtapz

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaamano @maiqueb @kyrtapz @openshift-ci-robot @openshift-merge-robot