OCPBUGS-11882: Added safe-to-evict annotation to ovnkube-master and multus admission controller components #1822
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@jparrill: This pull request references Jira Issue OCPBUGS-11882, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -53,6 +53,7 @@ spec: | |||
| annotations: | |||
| hypershift.openshift.io/release-image: {{.ReleaseImage}} | |||
| target.workload.openshift.io/management: '{"effect": "PreferredDuringScheduling"}' | |||
| cluster-autoscaler.kubernetes.io/safe-to-evict: "true" | |||
There was a problem hiding this comment.
does this annotation somehow skip PDBs? If so that's highly undesired and will need to use safe-to-evict-local-volumes https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-types-of-pods-can-prevent-ca-from-removing-a-node
How do those annotations differ?
There was a problem hiding this comment.
yeh we don't want this behaviour https://github.com/kubernetes/autoscaler/blob/d1740df93b76d99bf9302ad0c62978deb0ec1d5b/cluster-autoscaler/utils/drain/drain.go#L39-L40
/hold
There was a problem hiding this comment.
I've changed that just pointing to the EmptyDir concrete volumes. Also added to the multus-admission-controller deployment.
jparrill
changed the title
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
…us admission controller and cloud-network-config components Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-aws-ovn-network-migration |
|
/lgtm |
|
/test e2e-aws-ovn-network-migration |
2 similar comments
|
/test e2e-aws-ovn-network-migration |
|
/test e2e-aws-ovn-network-migration |
|
/override ci/prow/e2e-aws-ovn-network-migration |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, dcbw, jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-network-migration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jparrill: Jira Issue OCPBUGS-11882: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-11882 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes part of this bug: https://issues.redhat.com/browse/OCPBUGS-11882.
Basically adding this annotation to the pods which contains volumes or emptyDirs will allow the ClusterAutoscaler to drain the pods properly.