Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15138: Add kubernetes.io/os nodeSelector to wherebouts reconciler DS #1841

Merged
merged 1 commit into from Jun 20, 2023

Conversation

s1061123
Copy link
Contributor

This change adds nodeSelector to wherebouts reconciler to make consistency among multus related daemonset.

This change adds nodeSelector to wherebouts reconciler to make
consistency among multus related daemonset.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request references Jira Issue OCPBUGS-15138, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @aleskandro

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change adds nodeSelector to wherebouts reconciler to make consistency among multus related daemonset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from aleskandro June 19, 2023 08:09
@aleskandro
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 19, 2023
@openshift-ci openshift-ci bot requested review from jcaamano and trozet June 19, 2023 08:11
@s1061123
Copy link
Contributor Author

/retest

1 similar comment
@s1061123
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@s1061123: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dougbtv
Copy link
Member

dougbtv commented Jun 20, 2023

/lgtm

@dougbtv
Copy link
Member

dougbtv commented Jun 20, 2023

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6467b06 into openshift:master Jun 20, 2023
31 checks passed
@openshift-ci-robot
Copy link
Contributor

@s1061123: Jira Issue OCPBUGS-15138: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15138 has been moved to the MODIFIED state.

In response to this:

This change adds nodeSelector to wherebouts reconciler to make consistency among multus related daemonset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s1061123 s1061123 deleted the fix/ocp-15138 branch June 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants