Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15282: Add release version annotation to whereabouts-reconciler #1851

Conversation

jcaamano
Copy link
Contributor

CNO uses it to track whether updates to the daemonset have been done or
not. If not set, CNO won't set the overall operator version to the
target upgrade and the upgrade won't complete.

CNO uses it to track whether updates to the daemonset have been done or
not. If not set, CNO won't set the overall operator version to the
target upgrade and the upgrade won't complete.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano jcaamano changed the title Add release version annotation to whereabouts-reconciler OCPBUGS-15282: Add release version annotation to whereabouts-reconciler Jun 27, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-15282, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CNO uses it to track whether updates to the daemonset have been done or
not. If not set, CNO won't set the overall operator version to the
target upgrade and the upgrade won't complete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-15282, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-15282, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

@dougbtv @weliang1 PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@dougbtv
Copy link
Member

dougbtv commented Jun 27, 2023

/approve

@dougbtv
Copy link
Member

dougbtv commented Jun 27, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@jcaamano
Copy link
Contributor Author

jcaamano commented Jun 27, 2023

I will runt it once more short of overriding since I don't think it has anything to do

/retest-required

@jcaamano
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor Author

Not related, opened bug https://issues.redhat.com/browse/OCPBUGS-15475

/override ci/prow/e2e-vsphere-ovn-windows

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-vsphere-ovn-windows

In response to this:

Not related, opened bug https://issues.redhat.com/browse/OCPBUGS-15475

/override ci/prow/e2e-vsphere-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-hybrid-step-registry b897b33 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-vsphere-ovn-dualstack b897b33 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn b897b33 link false /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn b897b33 link false /test e2e-azure-ovn
ci/prow/e2e-openstack-ovn b897b33 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 64ab110 into openshift:master Jun 27, 2023
26 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcaamano: Jira Issue OCPBUGS-15282: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15282 has been moved to the MODIFIED state.

In response to this:

CNO uses it to track whether updates to the daemonset have been done or
not. If not set, CNO won't set the overall operator version to the
target upgrade and the upgrade won't complete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jcaamano: new pull request created: #1853

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants