Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15794: fix: add missing annotation for workload partitioning #1866

Conversation

eggfoobar
Copy link
Contributor

To support the workload partitioning we need to add this required annotations
(openshift/enhancements#703).

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

@eggfoobar: This pull request references Jira Issue OCPBUGS-15794, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

To support the workload partitioning we need to add this required annotations
(openshift/enhancements#703).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/assign @dcbw

@dcbw
Copy link
Contributor

dcbw commented Jul 6, 2023

/approve
/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 329e328 and 2 for PR HEAD 440054f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 660d5bc and 1 for PR HEAD 440054f in total

@eggfoobar
Copy link
Contributor Author

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3a5af01 and 0 for PR HEAD 440054f in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 440054f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

/unhold

The original failure was due to unrelated hypershift provisioning

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 47c5d16 and 2 for PR HEAD 440054f in total

@eggfoobar
Copy link
Contributor Author

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2023

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 440054f link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn 440054f link false /test e2e-openstack-ovn
ci/prow/e2e-ovn-hybrid-step-registry 440054f link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-vsphere-ovn-dualstack 440054f link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 7b9b0c2 into openshift:master Jul 9, 2023
27 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@eggfoobar: Jira Issue OCPBUGS-15794: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15794 has been moved to the MODIFIED state.

In response to this:

To support the workload partitioning we need to add this required annotations
(openshift/enhancements#703).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants