Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove oldest ovn acl log files when file limit exceeded" #1873 #1873

Merged

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jul 7, 2023

Reverts #1868

Caused 4.14 ci release stream to block
https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-07-07-055606

Container ovn-acl-logging is crashing with /bin/bash: line 31: log_dir: unbound variable

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

@sjenning: This pull request references Jira Issue OCPBUGS-10765, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1868

Caused 4.14 ci release stream to block
https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-07-07-055606

Container ovn-acl-logging is crashing with /bin/bash: line 31: log_dir: unbound variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

stbenjam commented Jul 7, 2023

/skip
/lgtm
/label approved

@stbenjam
Copy link
Member

stbenjam commented Jul 7, 2023

/retitle Revert "Remove oldest ovn acl log files when file limit exceeded" #1873

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-ci openshift-ci bot changed the title Revert "OCPBUGS-10765: Remove oldest ovn acl log files when file limit exceeded" Revert "Remove oldest ovn acl log files when file limit exceeded" #1873 Jul 7, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

@sjenning: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Reverts #1868

Caused 4.14 ci release stream to block
https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-07-07-055606

Container ovn-acl-logging is crashing with /bin/bash: line 31: log_dir: unbound variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 7, 2023
@openshift-ci openshift-ci bot requested review from jcaamano and trozet July 7, 2023 14:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2023
@stbenjam
Copy link
Member

stbenjam commented Jul 7, 2023

/override ci/prow/e2e-aws-ovn-network-migration
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-aws-sdn-multi
/override ci/prow/e2e-aws-sdn-network-migration-rollback
/override ci/prow/e2e-aws-sdn-network-reverse-migration
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-sdn
/override ci/prow/e2e-hypershift-ovn
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn-windows

We're returning to a previously known-good state. Forcing in to unblock payloads

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-network-migration, ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-aws-sdn-multi, ci/prow/e2e-aws-sdn-network-migration-rollback, ci/prow/e2e-aws-sdn-network-reverse-migration, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-sdn, ci/prow/e2e-hypershift-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-network-migration
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-aws-sdn-multi
/override ci/prow/e2e-aws-sdn-network-migration-rollback
/override ci/prow/e2e-aws-sdn-network-reverse-migration
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-sdn
/override ci/prow/e2e-hypershift-ovn
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn-windows

We're returning to a previously known-good state. Forcing in to unblock payloads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

stbenjam commented Jul 7, 2023

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3a5af01 into openshift:master Jul 7, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants