Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-17721: Enhance check controller to remove old check objects #1950

Merged
merged 2 commits into from Aug 24, 2023
Merged

[release-4.13] OCPBUGS-17721: Enhance check controller to remove old check objects #1950

merged 2 commits into from Aug 24, 2023

Conversation

pperiyasamy
Copy link
Member

Backport of relevant 4.14 commits 0d78f7c and 09086a7.

No Conflicts.

@pperiyasamy
Use apply config for check objects
b8a0f61 
This commit makes connectivity check controller to use new api from
library-go which is based on server side apply for syncing check
objects. This allows controller to apply check objects directly on
kube api server without need for checking existing object fields
and then calling update function.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 0d78f7c)
@pperiyasamy
Enhance controller to remove stale check objects
0f2a026 
This commit would make connectivitycheck controller to use new library-go
api so that stale checks objects are removed automatically as part
of controller sync.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 09086a7)
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-17721, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1341 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1341 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @mffiedler

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of relevant 4.14 commits 0d78f7c and 09086a7.

No Conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

/assign @kyrtapz @jcaamano @flavio-fernandes

@flavio-fernandes
Copy link
Contributor

/retest-required

flavio-fernandes
flavio-fernandes reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@kyrtapz
Copy link
Contributor

kyrtapz commented Aug 24, 2023

/lgtm

@jcaamano
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jcaamano, kyrtapz, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@mffiedler
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 24, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 10a5ac5 and 2 for PR HEAD 0f2a026 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023 •
edited

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 0f2a026 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack 0f2a026 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 6ba9a20 into openshift:release-4.13 Aug 24, 2023
29 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: Jira Issue OCPBUGS-17721: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17721 has been moved to the MODIFIED state.

In response to this:

Backport of relevant 4.14 commits 0d78f7c and 09086a7.

No Conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-08-28-112532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio-fernandes flavio-fernandes flavio-fernandes left review comments

@mffiedler mffiedler Awaiting requested review from mffiedler

@abhat abhat Awaiting requested review from abhat

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@flavio-fernandes flavio-fernandes

@eurijon eurijon

@kyrtapz kyrtapz

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet