Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17677: [Azure]CNCC failed to assign egressIP to NIC for Azure Workload Identity Cluster #1980

Merged
merged 1 commit into from Sep 6, 2023
Merged

OCPBUGS-17677: [Azure]CNCC failed to assign egressIP to NIC for Azure Workload Identity Cluster #1980

merged 1 commit into from Sep 6, 2023

Conversation

abutcher
Copy link
Member

Adds additional missing permission Microsoft.Network/loadBalancers/backendAddressPools/join/action.

OCPBUGS-17677
/cc @huiran0826

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 31, 2023
@openshift-ci openshift-ci bot requested a review from huiran0826 August 31, 2023 13:40
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 31, 2023
@openshift-ci-robot
Copy link
Contributor

@abutcher: This pull request references Jira Issue OCPBUGS-17677, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adds additional missing permission Microsoft.Network/loadBalancers/backendAddressPools/join/action.

OCPBUGS-17677
/cc @huiran0826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

/retest-required

@abutcher
Copy link
Member Author

abutcher commented Sep 5, 2023

/test e2e-azure-ovn-manual-oidc

3 similar comments
@abutcher
Copy link
Member Author

abutcher commented Sep 5, 2023

/test e2e-azure-ovn-manual-oidc

@abutcher
Copy link
Member Author

abutcher commented Sep 5, 2023

/test e2e-azure-ovn-manual-oidc

@abutcher
Copy link
Member Author

abutcher commented Sep 6, 2023

/test e2e-azure-ovn-manual-oidc

@abutcher
Copy link
Member Author

abutcher commented Sep 6, 2023

@huiran0826 Is it possible to retest this with clusterbot workflow with the PR?

@sdodson
Copy link
Member

sdodson commented Sep 6, 2023

@zshi-redhat When do we think we can have these proposed permissions reviewed and approved?

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 6, 2023 •
edited

/lgtm
Although I haven't tested the change looks reasonable because we are attaching the interface to the backendAddressPool:
https://github.com/openshift/cloud-network-config-controller/blob/master/pkg/cloudprovider/azure.go#L162

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@zshi-redhat
Copy link
Contributor

@zshi-redhat When do we think we can have these proposed permissions reviewed and approved?

@sdodson Patryk just reviewed, we will have another eye on it and approve it tomorrow if not today.

trozet
trozet approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@trozet
Copy link
Contributor

trozet commented Sep 6, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@abutcher: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn c2def35 link false /test e2e-openstack-ovn
ci/prow/e2e-network-mtu-migration-ovn-ipv4 c2def35 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec c2def35 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-network-mtu-migration-sdn-ipv4 c2def35 link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-vsphere-ovn-dualstack c2def35 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-sdn-upgrade c2def35 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-network-mtu-migration-ovn-ipv6 c2def35 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-openstack-sdn c2def35 link false /test e2e-openstack-sdn
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic c2def35 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic
ci/prow/e2e-azure-ovn-manual-oidc c2def35 link false /test e2e-azure-ovn-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2755d9c into openshift:master Sep 6, 2023
23 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@abutcher: Jira Issue OCPBUGS-17677: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17677 has been moved to the MODIFIED state.

In response to this:

Adds additional missing permission Microsoft.Network/loadBalancers/backendAddressPools/join/action.

OCPBUGS-17677
/cc @huiran0826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@huiran0826 huiran0826 Awaiting requested review from huiran0826

Assignees

@kyrtapz kyrtapz

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@abutcher @openshift-ci-robot @zshi-redhat @sdodson @kyrtapz @trozet @openshift-merge-robot