Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17380: ipsec: fix oopsy from 2e3fc8e7a0 #1996

Merged
merged 4 commits into from Sep 11, 2023
Merged

OCPBUGS-17380: ipsec: fix oopsy from 2e3fc8e7a0 #1996

merged 4 commits into from Sep 11, 2023

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Sep 11, 2023 •
edited

this fixes OCPBUGS-17380

this include

  • fixing of the oopsy (actual bug)
  • improving liveness probe so it'll actually detect above cases
  • rename of ds for better clarity

@yuvalk
ipsec: fix oopsy from 2e3fc8e
ab40a71 
this fixes OCPBUGS-17380
@yuvalk
ipsec: improve liveness check
84f38d0 
it is better to verify traffic.
status will only fail if it's not running, whereas counting the traffic
also tells us if something is configured or not()
@yuvalk
ipsec: rename ipsec ds
58b8ae9 
the previous names were confusing.
ovn-ipsec-containerized - will be used as long as libreswan is not on
the host
ovn-ipsec-host - will be used if libreswan was deployed (for
north-south)

in both cases, the daemonset is used for e-w traffic (but in 2 different
ways) see commit 8961f43 for more info
@dcbw
Copy link
Contributor

dcbw commented Sep 11, 2023

/approve
/lgtm

@dcbw dcbw added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Sep 11, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@trozet
Copy link
Contributor

trozet commented Sep 11, 2023

/retitle: OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e

@openshift-ci openshift-ci bot changed the title ipsec: fix oopsy from 2e3fc8e7a0 : OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e7a0 Sep 11, 2023
@trozet
Copy link
Contributor

trozet commented Sep 11, 2023

/retitle OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e

@openshift-ci openshift-ci bot changed the title : OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e7a0 OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e7a01fc47cb213e77a033564d7babedc8b Sep 11, 2023
@trozet
Copy link
Contributor

trozet commented Sep 11, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@trozet: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Sep 11, 2023

/retitle OCPBUGS-17380: ipsec: fix oopsy from 2e3fc8e

@openshift-ci openshift-ci bot changed the title OCPBUGS-17380 ipsec: fix oopsy from 2e3fc8e7a01fc47cb213e77a033564d7babedc8b OCPBUGS-17380: ipsec: fix oopsy from 2e3fc8e7a0 Sep 11, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-17380, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this fixes OCPBUGS-17380

this include

  • fixing of the oopsy (actual bug)
  • improving liveness probe so it'll actually detect above cases
  • rename of ds for better clarity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Sep 11, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Jira Issue OCPBUGS-17380, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trozet
trozet approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, trozet, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 692a344 and 2 for PR HEAD c8db085 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@yuvalk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-network-mtu-migration-ovn-ipv4 c8db085 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec c8db085 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-network-mtu-migration-ovn-ipv6 c8db085 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-vsphere-ovn-dualstack c8db085 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-ovn-ipsec-step-registry c8db085 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn c8db085 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn c8db085 link false /test e2e-openstack-ovn
ci/prow/e2e-network-mtu-migration-sdn-ipv4 c8db085 link false /test e2e-network-mtu-migration-sdn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 619ceff into openshift:master Sep 11, 2023
25 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@yuvalk: Jira Issue OCPBUGS-17380: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17380 has been moved to the MODIFIED state.

In response to this:

this fixes OCPBUGS-17380

this include

  • fixing of the oopsy (actual bug)
  • improving liveness probe so it'll actually detect above cases
  • rename of ds for better clarity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Sep 12, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@dcbw: new pull request created: #1997

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@dougbtv dougbtv Awaiting requested review from dougbtv

@jcaamano jcaamano Awaiting requested review from jcaamano

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@trozet trozet

@dcbw dcbw

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yuvalk @dcbw @trozet @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot