Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18396: Fix config status MTU migration not being updated #2021

Merged
merged 1 commit into from Sep 26, 2023
Merged

OCPBUGS-18396: Fix config status MTU migration not being updated #2021

merged 1 commit into from Sep 26, 2023

Conversation

jcaamano
Copy link
Contributor

Render has side effects in the passed in operConfig that are reflected later on in the status when it is being updated. This stopped working when the the passed in operConfig was changed to a copy that was not then used when applying the status.

It makes sense to use the updated operConfig for everything that comes after, not just Render, so change that to fix the issue.

Fixes: #1952

@jcaamano
Copy link
Contributor Author

cc @kyrtapz

@jcaamano
Fix config status MTU migration not being updated
32e3e47 
Render has side effects in the passed in operConfig that are reflected
later on in the status when it is being updated. This stopped working
when the the passed in operConfig was changed to a copy that was not
then used when applying the status.

It makes sense to use the updated operConfig for everything that comes
after, not just Render, so change that to fix the issue.

Fixes: openshift#1952

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2023
@jcaamano
Copy link
Contributor Author

/retest

1 similar comment
@jcaamano
Copy link
Contributor Author

/retest

@jcaamano
Copy link
Contributor Author

/retitle OCPBUGS-18396: Fix config status MTU migration not being updated

@openshift-ci openshift-ci bot changed the title Fix config status MTU migration not being updated OCPBUGS-18396: Fix config status MTU migration not being updated Sep 25, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-18396, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Render has side effects in the passed in operConfig that are reflected later on in the status when it is being updated. This stopped working when the the passed in operConfig was changed to a copy that was not then used when applying the status.

It makes sense to use the updated operConfig for everything that comes after, not just Render, so change that to fix the issue.

Fixes: #1952

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/retest

@jcaamano
Copy link
Contributor Author

@dulek PTAL

Would #1988 and #2007 be reverted or stay with this change?

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@jcaamano
Copy link
Contributor Author

/test e2e-network-mtu-migration-ovn-ipv6

@jcaamano
Copy link
Contributor Author

ci/prow/e2e-network-mtu-migration-ovn-ipv6 seems to be fine, it failed on a final test data collection that has also been oberseved to fail in the normal ipv6 job:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/2030/pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6/1706259564141219840

@jcaamano
Copy link
Contributor Author

/test e2e-network-mtu-migration-ovn-ipv6

@trozet
Copy link
Contributor

trozet commented Sep 25, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Jira Issue OCPBUGS-18396, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Sep 25, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trozet
Copy link
Contributor

trozet commented Sep 25, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 32e3e47 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-vsphere-ovn 32e3e47 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn 32e3e47 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn-dualstack 32e3e47 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2b544dd into openshift:master Sep 26, 2023
29 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcaamano: Jira Issue OCPBUGS-18396: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18396 has been moved to the MODIFIED state.

In response to this:

Render has side effects in the passed in operConfig that are reflected later on in the status when it is being updated. This stopped working when the the passed in operConfig was changed to a copy that was not then used when applying the status.

It makes sense to use the updated operConfig for everything that comes after, not just Render, so change that to fix the issue.

Fixes: #1952

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@jcaamano: new pull request created: #2034

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

@dulek dulek mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@dougbtv dougbtv Awaiting requested review from dougbtv

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@trozet trozet

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jcaamano @openshift-ci-robot @kyrtapz @trozet @openshift-cherrypick-robot @openshift-merge-robot