Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-19623: multus: set MULTUS_NODE_NAME to filter pods to local node #2022

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 21, 2023

This is an automated cherry-pick of #2020

Resolves apiserver and worker node CPU/memory regression after openshift/multus-cni#181 landed by adding a piece that was forgotten in #1990

This allows multus to set an apiserver filter to only watch pods
on its own node. Should reduce memory usage as multus doesn't
care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS
which seems fairly unecessary.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19550 has been cloned as Jira Issue OCPBUGS-19623. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-19623: multus: set MULTUS_NODE_NAME to filter pods to local node

In response to this:

This is an automated cherry-pick of #2020

/assign dcbw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-19550: multus: set MULTUS_NODE_NAME to filter pods to local node [release-4.14] OCPBUGS-19623: multus: set MULTUS_NODE_NAME to filter pods to local node Sep 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19623, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19550 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19550 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2020

/assign dcbw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Sep 21, 2023

/approve
/lgtm

@dcbw dcbw added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 21, 2023
@dcbw dcbw added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19623, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19550 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19550 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

This is an automated cherry-pick of #2020

Resolves apiserver and worker node CPU/memory regression after openshift/multus-cni#181 landed by adding a piece that was forgotten in #1990

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Sep 22, 2023

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 22, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, kyrtapz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat
Copy link
Contributor

/retest

@dcbw
Copy link
Contributor

dcbw commented Sep 22, 2023

/test e2e-aws-ovn-network-migration

@dcbw
Copy link
Contributor

dcbw commented Sep 22, 2023

/retest-required

@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2a50cf6 into openshift:release-4.14 Sep 22, 2023
20 of 34 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19623: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19623 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2020

Resolves apiserver and worker node CPU/memory regression after openshift/multus-cni#181 landed by adding a piece that was forgotten in #1990

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-sdn 57c781c link false /test e2e-openstack-sdn
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic 57c781c link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic
ci/prow/e2e-openstack-ovn 57c781c link false /test e2e-openstack-ovn
ci/prow/e2e-aws-sdn-upgrade 57c781c link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-network-mtu-migration-ovn-ipv4 57c781c link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-network-mtu-migration-sdn-ipv4 57c781c link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 57c781c link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-vsphere-ovn-dualstack 57c781c link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-ovn-step-registry 57c781c link false /test e2e-ovn-step-registry
ci/prow/e2e-network-mtu-migration-ovn-ipv6 57c781c link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-aws-ovn-serial 57c781c link false /test e2e-aws-ovn-serial
ci/prow/e2e-ovn-ipsec-step-registry 57c781c link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-hypershift-ovn-kubevirt 57c781c link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-single-node 57c781c link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-23-035947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet