Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19715: Do not enable node admission webhook if the CNI is not OVN-Kubernetes #2030

Merged
merged 1 commit into from Sep 25, 2023
Merged

OCPBUGS-19715: Do not enable node admission webhook if the CNI is not OVN-Kubernetes #2030

merged 1 commit into from Sep 25, 2023

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Sep 25, 2023 •
edited

SDN is not modifying node objects and there is no need to configure the node webhook.
The pod webhook is still required by multus.

@kyrtapz
Do not enable node admission webhook if the CNI is not OVN-Kubernetes
b527e74 
SDN is not modifying node objects and there is no need to configure the node webhook.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Sep 25, 2023

/cc @jcaamano

@jcaamano
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7d6202c and 2 for PR HEAD b527e74 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Sep 25, 2023

/retest-required

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Sep 25, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz kyrtapz changed the title Do not enable node admission webhook if the CNI is not OVN-Kubernetes OCPBUGS-19715: Do not enable node admission webhook if the CNI is not OVN-Kubernetes Sep 25, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-19715, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

SDN is not modifying node objects and there is no need to configure the node webhook.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-19715, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

SDN is not modifying node objects and there is no need to configure the node webhook.
The pod webhook is still required by multus.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec b527e74 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-network-mtu-migration-ovn-ipv6 b527e74 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-network-mtu-migration-ovn-ipv4 b527e74 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-openstack-sdn b527e74 link false /test e2e-openstack-sdn
ci/prow/e2e-vsphere-ovn-dualstack b527e74 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-network-mtu-migration-sdn-ipv4 b527e74 link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-vsphere-ovn b527e74 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn b527e74 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ce520ed into openshift:master Sep 25, 2023
25 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-19715: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19715 has been moved to the MODIFIED state.

In response to this:

SDN is not modifying node objects and there is no need to configure the node webhook.
The pod webhook is still required by multus.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@kyrtapz: new pull request created: #2032

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@jcaamano jcaamano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyrtapz @jcaamano @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot