[release-4.14] OCPBUGS-19808: remove prestop hooks for northd, sbdbd and nbdb #2036
Conversation
JIRA: https://issues.redhat.com/browse/OCPBUGS-17391 when the prestop hook executes the ovn-ctl stop... command this causes the containers main script to exit which also propagates to the main container (PID 1) process which exits causing the container to exit. This is not neccessarily a problem except that with recent changes in CRI-O [0] there is some problem with how kubelet views this case. the containers are Exited for crio but seen as Ready from kubelet's perspective. Because of this, the pod gets stuck in Terminating state until it times out (~3m) and then containers will restart. removing the prestop hook let's the SIGTERM reach the configured trap (example [1]) run which effectively does the same thing as what the prestop hook would have done. This prevents the pod from being stuck in Terminating state. [0] cri-o/cri-o#7168 [1] https://github.com/openshift/cluster-network-operator/blob/c55f19132864a9d8fe347ad6a8280eaa2f60e839/bindata/network/ovn-kubernetes/self-hosted/single-zone-interconnect/ovnkube-master.yaml#L74-L82 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-17391 has been cloned as Jira Issue OCPBUGS-19808. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19808, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@jluhrsen: This pull request references Jira Issue OCPBUGS-19808, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/retest-required |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/tide refresh |
|
/test e2e-aws-sdn-network-migration-rollback |
sdodson
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, openshift-cherrypick-robot, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Adding |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws-sdn-network-migration-rollback |
openshift-merge-robot
merged commit 5195cbf
into
openshift:release-4.14
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-19808: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19808 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-09-29-231104 |
This is an automated cherry-pick of #1978
/assign jluhrsen