Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20076: Multus should determine kubeconfig path #2049

Merged
merged 1 commit into from Oct 5, 2023

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Oct 4, 2023

Otherwise, we have a report of a file not found due to a symlink issue

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 4, 2023
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Jira Issue OCPBUGS-20076, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Otherwise, we have a report of a file not found due to a symlink issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Jira Issue OCPBUGS-20076, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

Otherwise, we have a report of a file not found due to a symlink issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from abhat and tssurya October 4, 2023 14:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7f72374 and 2 for PR HEAD b433b79 in total

@dougbtv
Copy link
Member Author

dougbtv commented Oct 4, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Jira Issue OCPBUGS-20076, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

Otherwise, we have a report of a file not found due to a symlink issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@dougbtv
Copy link
Member Author

dougbtv commented Oct 4, 2023

/retitle OCPBUGS-20076: Multus should determine kubeconfig path

@openshift-ci openshift-ci bot changed the title OCPBUGS-20076: Multus should reference kubelet kubeconfig as directly mounted OCPBUGS-20076: Multus should determine kubeconfig path Oct 4, 2023
@dougbtv
Copy link
Member Author

dougbtv commented Oct 4, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Jira Issue OCPBUGS-20076, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Otherwise, we have a report of a file not found due to a symlink issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv
Copy link
Member Author

dougbtv commented Oct 4, 2023

/test e2e-gcp-sdn
/test e2e-metal-ipi-ovn-ipv6

@dougbtv
Copy link
Member Author

dougbtv commented Oct 5, 2023

/test e2e-metal-ipi-ovn-ipv6

func determineKubeConfigPath() string {
var kubeletKubeconfigPaths = []string{
"/var/lib/kubelet/kubeconfig", // Traditional OCP
"/etc/kubernetes/kubelet-kubeconfig", // IBM Managed OpenShift, see OCPBUGS-19795
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: reference the new bug OCPBUGS-20064?

@dougbtv
Copy link
Member Author

dougbtv commented Oct 5, 2023

/test e2e-metal-ipi-ovn-ipv6

@jcaamano
Copy link
Contributor

jcaamano commented Oct 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, jcaamano, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhat
Copy link
Contributor

abhat commented Oct 5, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@abhat
Copy link
Contributor

abhat commented Oct 5, 2023

The metal ipi failure has nothing to do with this change. the job has been permafailing with an ironic error.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@dougbtv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 1ae47f9 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-ovn 1ae47f9 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn-dualstack 1ae47f9 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn 1ae47f9 link false /test e2e-vsphere-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt 1ae47f9 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv6 1ae47f9 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-gcp-ovn-upgrade 1ae47f9 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 1ae47f9 link false /test e2e-metal-ipi-ovn-ipv6-ipsec

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 981e3b1 into openshift:master Oct 5, 2023
25 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@dougbtv: Jira Issue OCPBUGS-20076: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20076 has been moved to the MODIFIED state.

In response to this:

Otherwise, we have a report of a file not found due to a symlink issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-09-101435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants