Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-22244: Remove IPsec daemonset after disabling IPsec in OVN #2083

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-22244: Remove IPsec daemonset after disabling IPsec in OVN #2083

wants to merge 2 commits into from

Conversation

pperiyasamy
Copy link
Member

@pperiyasamy pperiyasamy commented Oct 25, 2023 •
edited

The ipsec daemonset pods are not removed currently because it keeps ovs monitor ipsec process running so that ovn disable ipsec option can be processed in ovs monitor script and then ipsec can be disabled in kernel.
Hence this PR makes operator to wait for ovn ipsec disable is rolled out into all nodes and then it goes out and remove ipsec daemonset.

@openshift-ci openshift-ci bot requested review from abhat and tssurya October 25, 2023 12:52
@pperiyasamy
Copy link
Member Author

/assign @yuvalk @jcaamano @kyrtapz

@pperiyasamy pperiyasamy changed the title Remove liveness probe when ipsec option is disabled Remove ipsec daemonset after rolling out disabling ipsec in ovn Oct 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please ask for approval from jcaamano. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy pperiyasamy changed the title Remove ipsec daemonset after rolling out disabling ipsec in ovn OCPBUGS-22244: Remove IPsec daemonset after disabling IPsec in OVN Oct 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-22244, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The ipsec daemonset pods are not removed currently because it keeps ovs monitor ipsec process running so that ovn disable ipsec option can be processed in ovs monitor script and then ipsec can be disabled in kernel.
Hence this PR makes operator to wait for ovn ipsec disable is rolled out into all nodes and then it goes out and remove ipsec daemonset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-22244, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Remove IPsec daemonset after disabling IPsec in OVN
582c7f1 
The IPsec daemonset pods are not removed currently because it maintains
IPsec state and keeps OVS IPsec monitor process keeps running so that
disable IPsec option set in OVN can be processed gracefully and then
IPsec can be disabled properly in the data plane.

Hence this commit makes network operator to wait for IPsec disable
option in OVN is rolled out completely into all nodes and then it
goes out and remove IPsec daemonset.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@pperiyasamy
Add unit tests for disabling IPsec
9140f71 
This commit adds relevant unit test to cover code changes
related to disable IPsec usecase.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023 •
edited

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt 9140f71 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 9140f71 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-dualstack 9140f71 link false /test e2e-azure-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Member Author

/retest-required

@pperiyasamy
Copy link
Member Author

Closing it as this case is addressed with PR #2087 already.

@pperiyasamy pperiyasamy closed this Dec 8, 2023
@pperiyasamy pperiyasamy deleted the disable-ipsec-liveness branch December 8, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@yuvalk yuvalk

@jcaamano jcaamano

@kyrtapz kyrtapz

Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pperiyasamy @openshift-ci-robot @yuvalk @jcaamano @kyrtapz