OCPBUGS-22995: Tighten the permissions on whereabouts.conf

[rhmdnd]

According to CIS benchmark guidance, all files according to networking configuration should only be read/writeable to the owner (600).

This commit updates the installation script that lays down the whereabouts.conf file to use permissions 600 instead of 644.

[rhmdnd]

CI errors seem suspicious:

level=info msg=Cluster operator cloud-controller-manager CloudConfigControllerDegraded is False with AsExpected: Cloud Config Controller works as expected
level=info msg=Cluster operator cloud-controller-manager CloudControllerOwner is True with AsExpected: Cluster Cloud Controller Manager Operator owns cloud controllers at 4.15.0-0.ci.test-2023-11-13-202728-ci-op-694vctmm-latest
level=error msg=Cluster operator network Degraded is True with NoOperConfig: No networks.operator.openshift.io cluster found
level=info msg=Use the following commands to gather logs from the cluster 

I wonder if setting 600 is causing something to break because it can't read the whereabouts.conf file.

[rhmdnd]

/test e2e-azure-ovn-dualstack

[abhat]

cc @dougbtv

[dougbtv]

/lgtm

[dougbtv]

/approve

[dougbtv]

Due to the low risk of a widespread systematic impact of this change, I think we can

/label acknowledge-critical-fixes-only

[rhmdnd]

@dougbtv do you know if the various e2e failures are transient? The traces looked like they were related to the network operator failing to come up, but I'm not 100% sure.

[rhmdnd]

Rebased to freshen up the test results.

[dougbtv]

/retest-required

[dougbtv]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dougbtv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhmdnd]

Looks like e2e-metal-ipi-ovn-ipv6 failed because one of the API servers didn't come up.

[rhmdnd]

/test e2e-metal-ipi-ovn-ipv6

[rhmdnd]

/retest-required

[openshift-ci]

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-dualstack	8e4561c	link	false	/test e2e-azure-ovn-dualstack
ci/prow/e2e-network-mtu-migration-ovn-ipv6	8d0535b	link	false	/test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	8d0535b	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-hypershift-ovn-kubevirt	8d0535b	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-openstack-ovn	8d0535b	link	false	/test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	8d0535b	link	false	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/security	8d0535b	link	false	/test security
ci/prow/e2e-ovn-hybrid-step-registry	8d0535b	link	false	/test e2e-ovn-hybrid-step-registry
ci/prow/e2e-ovn-ipsec-step-registry	8d0535b	link	false	/test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rhmdnd]

/retest-required

[rhmdnd]

@dougbtv looks like we have a clean run. Should be ready for another look.

[openshift-ci-robot]

@rhmdnd: This pull request references Jira Issue OCPBUGS-22995, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

According to CIS benchmark guidance, all files according to networking configuration should only be read/writeable to the owner (600).

This commit updates the installation script that lays down the whereabouts.conf file to use permissions 600 instead of 644.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kyrtapz]

/jira refresh

[openshift-ci-robot]

@kyrtapz: This pull request references Jira Issue OCPBUGS-22995, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiaojiey

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rhmdnd: Jira Issue OCPBUGS-22995: All pull requests linked via external trackers have merged:

• openshift/cluster-network-operator#2106

Jira Issue OCPBUGS-22995 has been moved to the MODIFIED state.

In response to this:

According to CIS benchmark guidance, all files according to networking configuration should only be read/writeable to the owner (600).

This commit updates the installation script that lays down the whereabouts.conf file to use permissions 600 instead of 644.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202403261946.p0.ge9ab6a9.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

[xiaojiey]

@dougbtv @kyrtapz @rhmdnd Could you please help to cherry-pick to all other supported releases 4.15/4.14/4.13/4.12? Thanks.

[rhmdnd]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@rhmdnd: new pull request created: #2324

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620