[release-4.14] OCPBUGS-24037: remove all managed fields used by old manager #2112
Conversation
jluhrsen
changed the title
jluhrsen
force-pushed
the
OCPBUGS-22293-4.14
branch
from
20efc5b
to
4b34097
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test ci/prow/e2e-aws-sdn-network-migration-rollback |
|
@jluhrsen: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/jira cherrypick OCPBUGS-22293 |
|
@jluhrsen: Jira Issue OCPBUGS-22293 has been cloned as Jira Issue OCPBUGS-24037. Will retitle bug to link to clone. WARNING: Failed to update the target version for the clone. Please update the target version manually. Full error below: Full error message.
customfield_12323140 - Field 'customfield_12323140' cannot be set. It is not on the appropriate screen, or unknown.: request failed. Please analyze the request body for more details. Status code: 400:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@jluhrsen: This pull request references Jira Issue OCPBUGS-24037, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jluhrsen
changed the title
|
/jira refresh |
|
@jluhrsen: This pull request references Jira Issue OCPBUGS-24037, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@jluhrsen: This pull request references Jira Issue OCPBUGS-24037, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jluhrsen
force-pushed
the
OCPBUGS-22293-4.14
branch
from
4b34097
to
861aeb6
Compare
|
/retest |
1 similar comment
|
/retest |
|
Based on #2112 (comment) i'm going to add all required to merge labels. |
sdodson
added
lgtm
openshift-ci
bot
assigned anuragthehatter, asood-rh, eurijon, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, rlobillo and weliang1
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: flavio-fernandes, jluhrsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/skip |
|
/retest |
1 similar comment
|
/retest |
|
the e2e-vsphere-ovn-windows job has a pass rate under 50% so it may take a few retests for it to pass |
|
/override ci/prow/e2e-vsphere-ovn-windows |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-vsphere-ovn-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jluhrsen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8cf22aa
into
openshift:release-4.14
|
@jluhrsen: Jira Issue OCPBUGS-24037: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24037 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.14.0-202401100355.p0.g8cf22aa.assembly.stream for distgit cluster-network-operator. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@jluhrsen: Jira Issue OCPBUGS-24037 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
the old manager "cluster-network-operator" was changed to "cluster-network-operator/operconfig" in 4.11 when server-side-apply was migrated to from client-side-apply. However, the old operator still had it's own managed fields and some interaction between those and the change to remove preStop hooks in ovnkube-master's daemonset containers was causing upgrades to stick in the network operator.
this will just remove the old manager (and it's managed fields) entirely. it's done before the update to apply the object instead of after.
JIRA: https://issues.redhat.com/browse/OCPBUGS-22293
deal w/ deprecated field manager before apply