SDN-4101: Remove HyperShift API dependency, Bump kubernetes dependencies #2128
Conversation
|
/test verify |
Signed-off-by: Patryk Diak <pdiak@redhat.com>
|
/test verify |
|
/retest |
|
/retest |
HyperShift API dependency was causing a lot of dependency issues. Remove it in favor of using an unstructured objects and some copied definitions. Signed-off-by: Patryk Diak <pdiak@redhat.com>
Remove HyperShift related replaces. Run go mod tidy && go mod vendor. Signed-off-by: Patryk Diak <pdiak@redhat.com>
Removed remaining replaces that are no longer required. Commands: go get k8s.io/api go get k8s.io/code-generator go get k8s.io/component-base go get k8s.io/kube-proxy go get k8s.io/client-go go get k8s.io/apiextensions-apiserver go mod tidy go mod vendor Signed-off-by: Patryk Diak <pdiak@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
kyrtapz
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kyrtapz: This pull request references SDN-4101 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test 4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
openshift-merge-bot
bot
merged commit ce7b11d
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.15.0-202311271250.p0.gce7b11d.assembly.stream for distgit cluster-network-operator. |
This PR removes the HyperShift API dependency and bumps kubernetes deps to v0.28.4.
Once we remove the SBDB route in HyperShift we could clean up the code by removing the
Servicesfield fromHostedControlPlane.