Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-25128: Update to go 1.19 and x/net 0.8.0 #2157

Merged
merged 1 commit into from Dec 12, 2023
Merged

[release-4.12] OCPBUGS-25128: Update to go 1.19 and x/net 0.8.0 #2157

merged 1 commit into from Dec 12, 2023

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Dec 11, 2023 •
edited

go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2
go mod vendor
go mod tidy

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 11, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-24758, which is invalid:

  • expected Jira Issue OCPBUGS-24758 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2 go mod vendor
go mod tidy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@jcaamano
Copy link
Contributor Author

/jira cherrypick OCPBUGS-24758

@openshift-ci-robot
Copy link
Contributor

@jcaamano: Jira Issue OCPBUGS-24758 has been cloned as Jira Issue OCPBUGS-25128. Will retitle bug to link to clone.
/retitle OCPBUGS-25128: OCPBUGS-24758: Update to go 1.17 and x/net 0.8.0

In response to this:

/jira cherrypick OCPBUGS-24758

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title OCPBUGS-24758: Update to go 1.17 and x/net 0.8.0 OCPBUGS-25128: OCPBUGS-24758: Update to go 1.17 and x/net 0.8.0 Dec 11, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-25128, which is invalid:

  • expected dependent Jira Issue OCPBUGS-24758 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2 go mod vendor
go mod tidy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/retitle [release-4.12] OCPBUGS-25128: Update to go 1.19 and x/net 0.8.0

@openshift-ci openshift-ci bot changed the title OCPBUGS-25128: OCPBUGS-24758: Update to go 1.17 and x/net 0.8.0 [release-4.12] OCPBUGS-25128: Update to go 1.19 and x/net 0.8.0 Dec 11, 2023
@jcaamano
Update to go 1.19 and x/net 0.8.0
dd4cc49 
go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2
go mod vendor
go mod tidy

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano
Copy link
Contributor Author

/retest

@jcaamano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-25128, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24758 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24758 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

@kyrtapz PTAL

@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-25128, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24758 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24758 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2
go mod vendor
go mod tidy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@jcaamano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec dd4cc49 link false /test e2e-metal-ipi-ovn-ipv6-ipsec

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 12, 2023
@jechen0648
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9b9e946 into openshift:release-4.12 Dec 12, 2023
28 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcaamano: Jira Issue OCPBUGS-25128: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25128 has been moved to the MODIFIED state.

In response to this:

go mod edit -go 1.19
go get golang.org/x/net@v0.8.0
go get k8s.io/apiserver/pkg/authentication/token/cache@v0.25.2
go mod vendor
go mod tidy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.12.0-202312121603.p0.g9b9e946.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-12-12-182926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@dougbtv dougbtv Awaiting requested review from dougbtv

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@kyrtapz kyrtapz

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet