Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release 4.12] OCPBUGS-23025: Add maxLogFiles config for OVN-K Audit Logging #2188

Merged
merged 3 commits into from Jan 18, 2024
Merged

[release 4.12] OCPBUGS-23025: Add maxLogFiles config for OVN-K Audit Logging #2188

merged 3 commits into from Jan 18, 2024

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Jan 5, 2024

No description provided.

@jluhrsen
update openshift/api ot get maxLogFiles config
6152862 
this was introduced to openshift/api release4.13 in this
commit:
  openshift/api@69142c5

update to that commit in go.mod; go mod tidy; go mod vendor

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Remove oldest ovn acl log files when file limit exceeded
fc28a73 
adds new api config for max log files with a default of 5 files.
once the /var/log/ovn/ folder has exceeded that limit, the oldest
files will be removed (one at a time) to keep within the limit.

pairing this w/ the maxFileSize configuration, the total storage
used for these log files can be limited.

JIRA: https://issues.redhat.com/browse/OCPBUGS-22896

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
run update-codegen after adding maxLogFiles cfg
1cf3b8e 
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 5, 2024
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: This pull request references Jira Issue OCPBUGS-23025, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22896 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22896 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 5, 2024

/retest

@abhat
Copy link
Contributor

abhat commented Jan 15, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@jechen0648
Copy link

jechen0648 commented Jan 16, 2024 •
edited

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@jechen0648: The label(s) /label cheery-pick-approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label cheery-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 16, 2024
@asood-rh
Copy link

/ocpbugs cc-qa

@asood-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: This pull request references Jira Issue OCPBUGS-23025, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22896 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22896 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcaamano
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1e4e81c and 2 for PR HEAD 1cf3b8e in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024 •
edited

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-ovn 1cf3b8e link false /test e2e-hypershift-ovn
ci/prow/e2e-openstack-sdn 1cf3b8e link false /test e2e-openstack-sdn
ci/prow/e2e-vsphere-ovn 1cf3b8e link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jluhrsen
Copy link
Contributor Author

/override e2e-aws-ovn-network-migration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@jluhrsen: jluhrsen unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override e2e-aws-ovn-network-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen
Copy link
Contributor Author

/test e2e-aws-ovn-network-migration

@openshift-merge-bot openshift-merge-bot bot merged commit d74dddd into openshift:release-4.12 Jan 18, 2024
26 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: Jira Issue OCPBUGS-23025: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23025 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.12.0-202401190520.p0.gd74dddd.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.

@jluhrsen jluhrsen deleted the OCPBUGS-23025 branch April 19, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asood-rh asood-rh Awaiting requested review from asood-rh

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@abhat abhat

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet