OCPBUGS-26492: Not set CNO to degraded if API server returns conflict error #2192
Conversation
In CNO, the network.operator CR can be updated by both operconfig and clusterconfig controllers. There is a chance that these two controllers may encounter a racing condition, resulting in conflict error. Normally, this type of error can be automatically recovered by retrying the operation. Therefore, we don't set CNO to degrade when encountering this error. Signed-off-by: Peng Liu <pliu@redhat.com>
pliurh
changed the title
openshift-ci-robot
added
jira/severity-important
|
@pliurh: This pull request references Jira Issue OCPBUGS-26492, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@pliurh: This pull request references Jira Issue OCPBUGS-26492, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/cc @kyrtapz |
|
/retest |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, pliurh, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/hold Revision cad1e26 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@pliurh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 7c7c54d
into
openshift:master
|
@pliurh: Jira Issue OCPBUGS-26492: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26492 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.16.0-202402131640.p0.g7c7c54d.assembly.stream.el9 for distgit cluster-network-operator. |
|
/cherry-pick release-4.15 |
|
@kyrtapz: new pull request created: #2275 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In CNO, the network.operator CR can be updated by both operconfig and clusterconfig controllers. There is a chance that these two controllers may encounter a racing condition, resulting in conflict error.
Normally, this type of error can be automatically recovered by retrying the operation. Therefore, we don't set CNO to degrade when encountering this error.