[release-4.14] OCPBUGS-24326: adminpolicybasedexternalroutes CR accepts an invalid IP address

[jordigilh]

Backport of the 4.15 fix to add a pattern validation in the IP field for the static hop that checks if the IP has a valid IPv4 or IPv6 format.

@npinaeva @jcaamano @trozet PTAL.

/cc @jechen0648

[openshift-ci-robot]

@jordigilh: This pull request references Jira Issue OCPBUGS-22729, which is invalid:

• expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-22729 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of the 4.15 fix to add a pattern validation in the IP field for the static hop that checks if the IP has a valid IPv4 or IPv6 format.

@npinaeva @jcaamano @trozet PTAL.

/cc @jechen0648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jordigilh: This pull request references Jira Issue OCPBUGS-24326, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-24298 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-24298 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of the 4.15 fix to add a pattern validation in the IP field for the static hop that checks if the IP has a valid IPv4 or IPv6 format.

@npinaeva @jcaamano @trozet PTAL.

/cc @jechen0648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jechen0648]

/ocpbugs cc-qa

[jechen0648]

/label qe-approved

[jechen0648]

/test e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic

[jechen0648]

/test e2e-metal-ipi-ovn-ipv6

[jechen0648]

/test e2e-metal-ipi-ovn-ipv6-ipsec

[jechen0648]

/test e2e-vsphere-ovn

[jechen0648]

/test e2e-vsphere-ovn-windows

[openshift-ci]

@jordigilh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	2ab0600	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-aws-sdn-upgrade	2ab0600	link	false	/test e2e-aws-sdn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	2ab0600	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-vsphere-ovn-dualstack	2ab0600	link	false	/test e2e-vsphere-ovn-dualstack
ci/prow/4.14-upgrade-from-stable-4.13-e2e-azure-ovn-upgrade	2ab0600	link	false	/test 4.14-upgrade-from-stable-4.13-e2e-azure-ovn-upgrade
ci/prow/e2e-openstack-kuryr	2ab0600	link	false	/test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jcaamano]

/lgtm
/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, jordigilh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asood-rh]

/label cherry-pick-approved

[openshift-ci-robot]

@jordigilh: Jira Issue OCPBUGS-24326 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Backport of the 4.15 fix to add a pattern validation in the IP field for the static hop that checks if the IP has a valid IPv4 or IPv6 format.

@npinaeva @jcaamano @trozet PTAL.

/cc @jechen0648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.14.0-202401171554.p0.gf62efe5.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.