Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28208: ipsec: fix oopsy from 2e3fc8e (cherry-pick of 980c08318e) #2222

Merged
merged 1 commit into from Feb 7, 2024

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Jan 25, 2024

this fixes OCPBUGS-28208

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-28208, which is invalid:

  • expected Jira Issue OCPBUGS-28208 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this fixes OCPBUGS-28208

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and trozet January 25, 2024 16:00
@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 25, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-28208, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18871 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18871 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 25, 2024

/retest

@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 25, 2024

as I wrote in the OCPBUG
this got in in #2093

@jcaamano can you plz review?

@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 27, 2024

/retest

1 similar comment
@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 27, 2024

/retest

@jcaamano
Copy link
Contributor

/lgtm
/approve
/label backport-risk-assessed

@yuvalk
Copy link
Contributor Author

yuvalk commented Jan 30, 2024

/retest

@jcaamano
Copy link
Contributor

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2024
@huiran0826
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-28208, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18871 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18871 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

this fixes OCPBUGS-28208

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link
Contributor

tssurya commented Feb 6, 2024

/tide refresh

@jcaamano
Copy link
Contributor

jcaamano commented Feb 7, 2024

/skip

@jcaamano
Copy link
Contributor

jcaamano commented Feb 7, 2024

/tide refresh

@jcaamano
Copy link
Contributor

jcaamano commented Feb 7, 2024

/override ci/prow/4.16-upgrade-from-stable-4.15-images

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/4.16-upgrade-from-stable-4.15-images

In response to this:

/override ci/prow/4.16-upgrade-from-stable-4.15-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor

jcaamano commented Feb 7, 2024

/override ci/prow/e2e-aws-live-migration-sdn-ovn

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-live-migration-sdn-ovn

In response to this:

/override ci/prow/e2e-aws-live-migration-sdn-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d87e80f and 2 for PR HEAD 809d5a9 in total

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@yuvalk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 79083e6 into openshift:release-4.13 Feb 7, 2024
41 checks passed
@openshift-ci-robot
Copy link
Contributor

@yuvalk: Jira Issue OCPBUGS-28208: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28208 has been moved to the MODIFIED state.

In response to this:

this fixes OCPBUGS-28208

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.13.0-202402071409.p0.g79083e6.assembly.stream.el8 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2024-02-07-170816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet