Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds #2237

Merged

Conversation

s1061123
Copy link
Contributor

This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.

This code changes cni-sysctl-allowlist ds without container network
interface because this ds does not require any network.
@s1061123
Copy link
Contributor Author

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Jan 31, 2024

/lgtm

@dougbtv
Copy link
Member

dougbtv commented Jan 31, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@s1061123: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-ipsec-step-registry 6a8e621 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 6a8e621 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade 6a8e621 link false /test 4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 6a8e621 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-network-mtu-migration-ovn-ipv6 6a8e621 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-network-mtu-migration-ovn-ipv4 6a8e621 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade 6a8e621 link false /test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
ci/prow/e2e-network-mtu-migration-sdn-ipv4 6a8e621 link false /test e2e-network-mtu-migration-sdn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 6, 2024

/retitle NO-JIRA Add hostNetwork:true to cni-sysctl-allowlist ds

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 6, 2024

/retitle NO-JIRA: Add hostNetwork:true to cni-sysctl-allowlist ds

@openshift-ci openshift-ci bot changed the title Add hostNetwork:true to cni-sysctl-allowlist ds NO-JIRA Add hostNetwork:true to cni-sysctl-allowlist ds Feb 6, 2024
@openshift-ci openshift-ci bot changed the title NO-JIRA Add hostNetwork:true to cni-sysctl-allowlist ds NO-JIRA: Add hostNetwork:true to cni-sysctl-allowlist ds Feb 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request explicitly references no jira issue.

In response to this:

This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request explicitly references no jira issue.

In response to this:

This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@s1061123
Copy link
Contributor Author

s1061123 commented Feb 6, 2024

/retitle OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds

@openshift-ci openshift-ci bot changed the title NO-JIRA: Add hostNetwork:true to cni-sysctl-allowlist ds OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds Feb 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request references Jira Issue OCPBUGS-29099, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 57c62eb into openshift:master Feb 6, 2024
33 of 41 checks passed
@openshift-ci-robot
Copy link
Contributor

@s1061123: Jira Issue OCPBUGS-29099: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29099 has been moved to the MODIFIED state.

In response to this:

This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202402070113.p0.g57c62eb.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-07-073830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants