New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds #2237
OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds #2237
Conversation
This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.
/retest-required |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@s1061123: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retitle NO-JIRA Add hostNetwork:true to cni-sysctl-allowlist ds |
/retitle NO-JIRA: Add hostNetwork:true to cni-sysctl-allowlist ds |
@s1061123: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@s1061123: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle OCPBUGS-29099: Add hostNetwork:true to cni-sysctl-allowlist ds |
@s1061123: This pull request references Jira Issue OCPBUGS-29099, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
57c62eb
into
openshift:master
@s1061123: Jira Issue OCPBUGS-29099: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29099 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.16.0-202402070113.p0.g57c62eb.assembly.stream.el9 for distgit cluster-network-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-07-073830 |
This code changes cni-sysctl-allowlist ds without container network interface because this ds does not require any network.