Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27222: Update CloudPrivateIPConfig definition #2239

Closed
wants to merge 1 commit into from

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Jan 31, 2024

openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot be created because of wrong name validation. This commit imports this change into the CRD created by CNO when deploying cloud-network-config-controller.

@dulek
Copy link
Contributor Author

dulek commented Jan 31, 2024

I'm not 100% sure this is the proper way to update API version, let's see.

@openshift-ci openshift-ci bot requested review from dcbw and kyrtapz January 31, 2024 12:55
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dulek
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 31, 2024

@dulek this should do it:

go get github.com/openshift/api@master
go mod tidy && go mod vendor
./hack/update-codegen.sh

Please add the commands ran into the commit message.

@dulek dulek force-pushed the update-api-cpic branch 2 times, most recently from 0c3f0d4 to 5477cca Compare January 31, 2024 14:11
go.mod Outdated
Comment on lines 3 to 5
go 1.21

toolchain go1.21.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyrtapz: Is this allowed? go mod tidy wants this.

go.sum Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyrtapz: And all these changes.

@dulek dulek changed the title Update CloudPrivateIPConfig definition OCPBUGS-27222: Update CloudPrivateIPConfig definition Jan 31, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Jira Issue OCPBUGS-27222, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot be created because of wrong name validation. This commit imports this change into the CRD created by CNO when deploying cloud-network-config-controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dulek
Copy link
Contributor Author

dulek commented Jan 31, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Jira Issue OCPBUGS-27222, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 31, 2024
openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot
be created because of wrong name validation. This commit imports this
change into the CRD created by CNO when deploying
cloud-network-config-controller.
@dulek
Copy link
Contributor Author

dulek commented Feb 1, 2024

/retest-required

Alright, this seems to look good now!

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-network-mtu-migration-sdn-ipv4 253be85 link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-vsphere-ovn-dualstack 253be85 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 253be85 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 253be85 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-vsphere-ovn 253be85 link false /test e2e-vsphere-ovn
ci/prow/e2e-aws-sdn-upgrade 253be85 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt 253be85 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv6 253be85 link false /test e2e-network-mtu-migration-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek
Copy link
Contributor Author

dulek commented Feb 1, 2024

Closing in favor of #2246.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-02-224339

@dulek dulek closed this Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Jira Issue OCPBUGS-27222. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot be created because of wrong name validation. This commit imports this change into the CRD created by CNO when deploying cloud-network-config-controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants