New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-27222: Update CloudPrivateIPConfig definition #2239
Conversation
I'm not 100% sure this is the proper way to update API version, let's see. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dulek this should do it:
Please add the commands ran into the commit message. |
0c3f0d4
to
5477cca
Compare
go.mod
Outdated
go 1.21 | ||
|
||
toolchain go1.21.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyrtapz: Is this allowed? go mod tidy
wants this.
go.sum
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyrtapz: And all these changes.
@dulek: This pull request references Jira Issue OCPBUGS-27222, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@dulek: This pull request references Jira Issue OCPBUGS-27222, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot be created because of wrong name validation. This commit imports this change into the CRD created by CNO when deploying cloud-network-config-controller.
5477cca
to
253be85
Compare
/retest-required Alright, this seems to look good now! |
@dulek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing in favor of #2246. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-02-224339 |
@dulek: This pull request references Jira Issue OCPBUGS-27222. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift/api#1727 fixes issue where IPv6 CloudPrivateIPConfigs cannot be created because of wrong name validation. This commit imports this change into the CRD created by CNO when deploying cloud-network-config-controller.