Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-28902: Fix CloudPrivateIPConfig CRD in common #2263

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Feb 8, 2024

update-codegen.sh only updated the top-level CRD as 001-crd.yaml in /bindata/cloud-network-config-controller and skipped the one in common subdirectory. This made #2246 to not actually update the CRD.

This commit makes sure the script is updated to put the file into the correct subdirectory.

`update-codegen.sh` only updated the top-level CRD as 001-crd.yaml in
`/bindata/cloud-network-config-controller` and skipped the one in
`common` subdirectory. This made openshift#2246 to not actually update the CRD.

This commit makes sure the script is updated to put the file into the
correct subdirectory.
@dulek dulek changed the title Fix CloudPrivateIPConfig CRD in common [release-4.15] OCPBUGS-27222: Fix CloudPrivateIPConfig CRD in common Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Jira Issue OCPBUGS-27222, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected Jira Issue OCPBUGS-27222 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

update-codegen.sh only updated the top-level CRD as 001-crd.yaml in /bindata/cloud-network-config-controller and skipped the one in common subdirectory. This made #2246 to not actually update the CRD.

This commit makes sure the script is updated to put the file into the correct subdirectory.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dulek dulek changed the title [release-4.15] OCPBUGS-27222: Fix CloudPrivateIPConfig CRD in common [release-4.15] OCPBUGS-28902: Fix CloudPrivateIPConfig CRD in common Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Jira Issue OCPBUGS-28902, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27222 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-27222 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (rlobillo@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

update-codegen.sh only updated the top-level CRD as 001-crd.yaml in /bindata/cloud-network-config-controller and skipped the one in common subdirectory. This made #2246 to not actually update the CRD.

This commit makes sure the script is updated to put the file into the correct subdirectory.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dulek
Copy link
Contributor Author

dulek commented Feb 8, 2024

@kyrtapz: Hopefully this is the last one!

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 9, 2024

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 9, 2024

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 9, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@jechen0648
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 9, 2024
@jechen0648
Copy link

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit b45e718 into openshift:release-4.15 Feb 9, 2024
37 of 42 checks passed
@openshift-ci-robot
Copy link
Contributor

@dulek: Jira Issue OCPBUGS-28902: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28902 has been moved to the MODIFIED state.

In response to this:

update-codegen.sh only updated the top-level CRD as 001-crd.yaml in /bindata/cloud-network-config-controller and skipped the one in common subdirectory. This made #2246 to not actually update the CRD.

This commit makes sure the script is updated to put the file into the correct subdirectory.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@dulek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 63afbbd link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.15.0-202402091607.p0.gb45e718.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet