New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-28902: Fix CloudPrivateIPConfig CRD in common #2263
[release-4.15] OCPBUGS-28902: Fix CloudPrivateIPConfig CRD in common #2263
Conversation
`update-codegen.sh` only updated the top-level CRD as 001-crd.yaml in `/bindata/cloud-network-config-controller` and skipped the one in `common` subdirectory. This made openshift#2246 to not actually update the CRD. This commit makes sure the script is updated to put the file into the correct subdirectory.
@dulek: This pull request references Jira Issue OCPBUGS-27222, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dulek: This pull request references Jira Issue OCPBUGS-28902, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (rlobillo@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kyrtapz: Hopefully this is the last one! |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
/retest |
b45e718
into
openshift:release-4.15
@dulek: Jira Issue OCPBUGS-28902: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28902 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dulek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.15.0-202402091607.p0.gb45e718.assembly.stream.el9 for distgit cluster-network-operator. |
Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938 |
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
update-codegen.sh
only updated the top-level CRD as 001-crd.yaml in/bindata/cloud-network-config-controller
and skipped the one incommon
subdirectory. This made #2246 to not actually update the CRD.This commit makes sure the script is updated to put the file into the correct subdirectory.