Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29403: add more safe sysctls #2273

Merged
merged 1 commit into from
May 9, 2024
Merged

OCPBUGS-29403: add more safe sysctls #2273

merged 1 commit into from
May 9, 2024

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Feb 13, 2024

I've left out forwarding for now
still want to understand why they want it and what it relates to

it is safe, but might make our support life .. complicated

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2024
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-29403, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

I've left out forwarding for now
still want to understand why they want it and what it relates to

it is safe, but might make our support life .. complicated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuvalk
Copy link
Contributor Author

yuvalk commented Mar 5, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2024
@openshift-ci-robot
Copy link
Contributor

@yuvalk: This pull request references Jira Issue OCPBUGS-29403, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dougbtv
Copy link
Member

dougbtv commented May 7, 2024

/lgtm

@dougbtv
Copy link
Member

dougbtv commented May 7, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2129174 and 2 for PR HEAD a6fbafe in total

@yuvalk
Copy link
Contributor Author

yuvalk commented May 7, 2024

/retest

@yuvalk
Copy link
Contributor Author

yuvalk commented May 8, 2024

/retest-required

@yuvalk
Copy link
Contributor Author

yuvalk commented May 8, 2024

/test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024 •
edited

@yuvalk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack a6fbafe link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn a6fbafe link false /test e2e-vsphere-ovn
ci/prow/4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade a6fbafe link false /test 4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
ci/prow/e2e-ovn-ipsec-step-registry a6fbafe link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback a6fbafe link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade a6fbafe link false /test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec a6fbafe link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/security a6fbafe link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 a6fbafe link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade a6fbafe link false /test 4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuvalk
Copy link
Contributor Author

yuvalk commented May 9, 2024

/test ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@yuvalk: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade
  • /test 4.16-upgrade-from-stable-4.15-images
  • /test e2e-aws-live-migration-sdn-ovn
  • /test e2e-aws-ovn-hypershift-conformance
  • /test e2e-aws-ovn-network-migration
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-windows
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
  • /test 4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade
  • /test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
  • /test e2e-aws-hypershift-ovn-kubevirt
  • /test e2e-aws-live-migration-sdn-ovn-rollback
  • /test e2e-aws-ovn-ipsec-upgrade
  • /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-sdn-upgrade
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-dualstack
  • /test e2e-azure-ovn-manual-oidc
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-metal-ipi-ovn-ipv6-ipsec
  • /test e2e-network-mtu-migration-ovn-ipv4
  • /test e2e-network-mtu-migration-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-ovn-ipsec-step-registry
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-dualstack
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-windows
  • /test okd-scos-images
  • /test qe-perfscale-aws-ovn-medium-cluster-density
  • /test qe-perfscale-aws-ovn-medium-node-density-cni
  • /test qe-perfscale-aws-ovn-small-cluster-density
  • /test qe-perfscale-aws-ovn-small-node-density-cni
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-network-operator-master-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-4.16-upgrade-from-stable-4.15-images
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-hypershift-ovn-kubevirt
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-live-migration-sdn-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-live-migration-sdn-ovn-rollback
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-hypershift-conformance
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-network-migration
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-windows
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-sdn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6-ipsec
  • pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv4
  • pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-master-e2e-openstack-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-ipsec-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack-primaryv6
  • pull-ci-openshift-cluster-network-operator-master-images
  • pull-ci-openshift-cluster-network-operator-master-lint
  • pull-ci-openshift-cluster-network-operator-master-security
  • pull-ci-openshift-cluster-network-operator-master-unit
  • pull-ci-openshift-cluster-network-operator-master-verify

In response to this:

/test ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yuvalk
Copy link
Contributor Author

yuvalk commented May 9, 2024

/test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

1 similar comment
@yuvalk
Copy link
Contributor Author

yuvalk commented May 9, 2024

/test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

@openshift-merge-bot openshift-merge-bot bot merged commit 3bb2096 into openshift:master May 9, 2024
28 of 38 checks passed
@openshift-ci-robot
Copy link
Contributor

@yuvalk: Jira Issue OCPBUGS-29403: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29403 has been moved to the MODIFIED state.

In response to this:

I've left out forwarding for now
still want to understand why they want it and what it relates to

it is safe, but might make our support life .. complicated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202405100946.p0.g3bb2096.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-14-095225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dougbtv dougbtv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuvalk @openshift-ci-robot @dougbtv @openshift-bot @openshift-merge-robot