-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy networking-console-plugin by CNO #2322
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
393616f
to
1c1cda6
Compare
1c1cda6
to
a190e55
Compare
8aa4cb5
to
ab23388
Compare
/test e2e-metal-ipi-ovn-ipv6 |
28131a8
to
dd2941b
Compare
01a6a50
to
cc3c51c
Compare
return nil, nil | ||
} | ||
|
||
tmpFallbackConsoleImage := "quay.io/orenc/networking-console-plugin:4.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like in an hypershift hosted cluster, the CNO deployment on the hosted control plane is not getting populated with the NETWORKING_CONSOLE_PLUGIN_IMAGE
env var.
could you please advise how can we inject it in that case?
this is required so hypershift's control-plane-operator will be able to deploy CNO with this image, extracted from the release payload. this PR is a prerequisite for openshift#2322 Signed-off-by: Oren Cohen <ocohen@redhat.com>
this is required so hypershift's control-plane-operator will be able to deploy CNO with this image, extracted from the release payload. this PR is a prerequisite for openshift#2322 Signed-off-by: Oren Cohen <ocohen@redhat.com>
@orenc1 could you catch up on this? It's a test blocker. |
Use the CNO operator config controller to deploy and reconcile the resources required to enable the new Networking console plugin: * Deployment * Service * ConfigMap (for nginx config) * ConsolePlugin Signed-off-by: Oren Cohen <ocohen@redhat.com>
cc3c51c
to
1036192
Compare
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Use the CNO operator config controller to deploy and reconcile the resources required to enable the new Networking console plugin:
Also, enables the console plugin by adding it to the cluster Console plugins list.
Jira ticket: https://issues.redhat.com/browse/CONSOLE-3952