Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29572: Apply hypershift cluster-profile for ibm-cloud-managed #2343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Apr 18, 2024

We need good developer docs in CNO so that other teams can contribute properly; its a maze today

Helping out with #2277 since that bot PR had a red verify lane.

Context:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Credit to @ashwindasr who has worked behind the scenes and is driving this effort from ART side.

@openshift-ci openshift-ci bot requested review from abhat and kyrtapz April 18, 2024 18:55
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The bot missed this patch change which is
needed to satify verify in CI

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya tssurya changed the title [DNM] Art+patch OCPBUGS-29572: Apply hypershift cluster-profile for ibm-cloud-managed Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-29572, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We need good developer docs in CNO so that other teams can contribute properly; its a maze today

Helping out with #2277 since that bot PR had a red verify lane.

Context:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 18, 2024
@openshift-ci openshift-ci bot requested a review from zhaozhanqi April 18, 2024 19:08
@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-29572, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

We need good developer docs in CNO so that other teams can contribute properly; its a maze today

Helping out with #2277 since that bot PR had a red verify lane.

Context:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Credit to @ashwindasr who has worked behind the scenes and is driving this effort from ART side.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link

/retest

2 similar comments
@ashwindasr
Copy link

/retest

@ashwindasr
Copy link

/retest

@ashwindasr
Copy link

/test e2e-vsphere-ovn-dualstack-primaryv6

1 similar comment
@ashwindasr
Copy link

/test e2e-vsphere-ovn-dualstack-primaryv6

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security b769052 link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 b769052 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade b769052 link true /test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssurya
Copy link
Contributor Author

tssurya commented May 13, 2024

@kyrtapz : PTAL, I think you mentioned some concerns over this PR right? cc @ashwindasr

@kyrtapz
Copy link
Contributor

kyrtapz commented May 13, 2024

@kyrtapz : PTAL, I think you mentioned some concerns over this PR right? cc @ashwindasr

Thanks for the ping. So I have two concerns:

  • Some of the changed files are vendored in from the API, why can't we add the annotation directly in the API repo? @ashwindasr
  • We need to update the hack/update-codegen.sh script so it doesn't overwrite the changes in this pr

@ashwindasr
Copy link

Thanks @kyrtapz

Working on the API changes, which are a bit more complicated. So once thats in, we can adjust and back port.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants