New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29572: Apply hypershift cluster-profile for ibm-cloud-managed #2343
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tssurya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The bot missed this patch change which is needed to satify verify in CI Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya: This pull request references Jira Issue OCPBUGS-29572, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@tssurya: This pull request references Jira Issue OCPBUGS-29572, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
2 similar comments
/retest |
/retest |
/test e2e-vsphere-ovn-dualstack-primaryv6 |
1 similar comment
/test e2e-vsphere-ovn-dualstack-primaryv6 |
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@kyrtapz : PTAL, I think you mentioned some concerns over this PR right? cc @ashwindasr |
Thanks for the ping. So I have two concerns:
|
Thanks @kyrtapz Working on the API changes, which are a bit more complicated. So once thats in, we can adjust and back port. /hold |
We need good developer docs in CNO so that other teams can contribute properly; its a maze today
Helping out with #2277 since that bot PR had a red verify lane.
Context:
Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS
Credit to @ashwindasr who has worked behind the scenes and is driving this effort from ART side.