Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23758: Set global IP forwarding sysctl parameters while starting ovnkube-node #2385

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

arghosh93
Copy link
Contributor

This PR is to set IPv4 and IPv6 IP forwarding sysctl parameter when ipForwarding mode is set to Restricted.

If ipForwarding is set to 'Restricted':

sysctl -w net.ipv4.ip_forward=0
sysctl -w net.ipv6.conf.all.forwarding=0

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 24, 2024
@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-23758, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is to set IPv4 and IPv6 IP forwarding sysctl parameter when ipForwarding mode is set to Restricted.

If ipForwarding is set to 'Restricted':

sysctl -w net.ipv4.ip_forward=0
sysctl -w net.ipv6.conf.all.forwarding=0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and tssurya May 24, 2024 13:57
Copy link
Contributor

openshift-ci bot commented May 24, 2024

Hi @arghosh93. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2024
@tssurya
Copy link
Contributor

tssurya commented May 27, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024
@tssurya
Copy link
Contributor

tssurya commented May 27, 2024

/jira refresh

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@arghosh93
Copy link
Contributor Author

/retest

@arghosh93
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 3, 2024
@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-23758, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 3, 2024
@openshift-ci openshift-ci bot requested a review from huiran0826 June 3, 2024 03:35
@arghosh93
Copy link
Contributor Author

/retest-required

1 similar comment
@arghosh93
Copy link
Contributor Author

/retest-required

…troller

This PR is to set IPv4 and IPv6 IP forwarding sysctl parameters when
ipForwarding mode is set to Restricted.

If ipForwarding is set to 'Restricted':

sysctl -w net.ipv4.ip_forward=0
sysctl -w net.ipv6.conf.all.forwarding=0

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
@arghosh93
Copy link
Contributor Author

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Jun 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghosh93, kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 32e733b and 2 for PR HEAD 3955a9a in total

@arghosh93
Copy link
Contributor Author

/retest-required

2 similar comments
@arghosh93
Copy link
Contributor Author

/retest-required

@arghosh93
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-live-migration-sdn-ovn 0cd356f link true /test e2e-aws-live-migration-sdn-ovn
ci/prow/e2e-aws-ovn-network-migration 0cd356f link true /test e2e-aws-ovn-network-migration
ci/prow/security 3955a9a link false /test security
ci/prow/e2e-vsphere-ovn 3955a9a link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack 3955a9a link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 3955a9a link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arghosh93
Copy link
Contributor Author

/cherrypick release-4.16

@openshift-cherrypick-robot

@arghosh93: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deepsm007
Copy link

/test okd-scos-images

@openshift-merge-bot openshift-merge-bot bot merged commit 4b792c6 into openshift:master Jun 26, 2024
32 of 36 checks passed
@openshift-ci-robot
Copy link
Contributor

@arghosh93: Jira Issue OCPBUGS-23758: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23758 has been moved to the MODIFIED state.

In response to this:

This PR is to set IPv4 and IPv6 IP forwarding sysctl parameter when ipForwarding mode is set to Restricted.

If ipForwarding is set to 'Restricted':

sysctl -w net.ipv4.ip_forward=0
sysctl -w net.ipv6.conf.all.forwarding=0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@arghosh93: new pull request created: #2422

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@arghosh93: new pull request could not be created: failed to create pull request against openshift/cluster-network-operator#release-4.16 from head openshift-cherrypick-robot:cherry-pick-2385-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2385-to-release-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.17.0-202406261807.p0.g4b792c6.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants