Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding egress IP addresses to the CRD output #241

Merged
merged 1 commit into from Jul 18, 2019
Merged

Adding egress IP addresses to the CRD output #241

merged 1 commit into from Jul 18, 2019

Conversation

alexanderConstantinescu
Copy link
Contributor

This addresses bug 1707749

Please let me know if the description should be modified.

/Alex

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2019
@alexanderConstantinescu
Copy link
Contributor Author

/assign @squeed

@danwinship
Copy link
Contributor

What output does this result in? I thought I had tried this before and determined that the CRD printer didn't support array-valued columns.

@alexanderConstantinescu
Copy link
Contributor Author

alexanderConstantinescu commented Jul 16, 2019 •
edited

What output does this result in? I thought I had tried this before and determined that the CRD printer didn't support array-valued columns.

Screenshot from 2019-07-16 15-40-22

Please find an attached screenshot of a local edit with bogus IPs. Check the openshift-sdn entry

danwinship
danwinship reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'd swear that didn't work before... maybe it only started working after the rebase to kube 1.14?

bindata/network/openshift-sdn/001-crd.yaml Outdated
@@ -117,6 +117,10 @@ spec:
type: string
description: The CIDR range of the overlay network assigned to the node for its pods
JSONPath: .subnet
- name: EgressIPs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HostSubnet, you should also print the EgressCIDRs, before the EgressIPs. (https://github.com/openshift/origin/blob/release-3.11/pkg/printers/internalversion/printer.go#L66)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2019
@alexanderConstantinescu
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 80a7afb into openshift:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@squeed squeed Awaiting requested review from squeed

Assignees

@danwinship danwinship

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexanderConstantinescu @danwinship @openshift-ci-robot @openshift-bot @squeed @openshift-merge-robot