Fixes Bug 1757973: Removes external api server from default noProxy

[danehans]

External cluster resources such as routes should not be automatically no-proxied. We should provide cluster admins the choice on whether or not to proxy these connections. This PR removes the external api-server hostname from the default noProxy list.

/assign @bparees @deads2k @knobunc

[bparees]

definitely would like @deads2k to confirm, but i believe this is correct per the slack discussion.

[squeed]

This makes sense. Normally, services of type LoadBalancer still have ClusterIPs, but since this LB is managed by the installer (Terraform), we don't get that kind of behavior.

[danehans]

Associated installer PR: openshift/installer#2425

[danehans]

/hold

until openshift/installer#2425 (comment) is confirmed whether a bug should be filed and verification from @deads2k

[openshift-ci-robot]

@danehans: This pull request references Bugzilla bug 1757973, which is invalid:

• expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes Bug 1757973: Removes external api server from default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danehans]

@squeed based on openshift/installer#2425 (comment), I created Bugzilla bug 1757973 but the bot is unhappy with something in the bug definition.

[bparees]

/bugzilla refresh

@danehans i made the same update here.

[openshift-ci-robot]

@bparees: This pull request references Bugzilla bug 1757973, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

@danehans i made the same update here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knobunc]

/lgtm
/approve

Thanks Dane.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danehans]

/hold cancel

[openshift-ci-robot]

@danehans: All pull requests linked via external trackers have merged. Bugzilla bug 1757973 has been moved to the MODIFIED state.

In response to this:

Fixes Bug 1757973: Removes external api server from default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danehans]

/cherry-pick release-4.2

[openshift-cherrypick-robot]

@danehans: #328 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/util/proxyconfig/no_proxy.go
M	pkg/util/proxyconfig/no_proxy_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/util/proxyconfig/no_proxy_test.go
CONFLICT (content): Merge conflict in pkg/util/proxyconfig/no_proxy_test.go
Auto-merging pkg/util/proxyconfig/no_proxy.go
Patch failed at 0001 Removes external api server from default noProxy

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@danehans: All pull requests linked via external trackers have merged. Bugzilla bug 1758642 has been moved to the MODIFIED state.

In response to this:

Fixes Bug 1758642: Removes external api server from default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@danehans: Bugzilla bug 1757973 is in an unrecognized state (CLOSED (NOTABUG)) and will not be moved to the MODIFIED state.

In response to this:

Fixes Bug 1757973: Removes external api server from default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.