Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn custom geneve port number #341

Merged
merged 1 commit into from Jan 3, 2020
Merged

ovn custom geneve port number #341

merged 1 commit into from Jan 3, 2020

Conversation

pecameron
Copy link
Contributor

SDN-494 - ovn custom geneve port number.
https://jira.coreos.com/browse/SDN-494

Signed-off-by: Phil Cameron pcameron@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2019
@pecameron
Copy link
Contributor Author

@dcbw @danwinship @squeed PTAL

danwinship
danwinship requested changes Oct 8, 2019
View reviewed changes
HACKING.md Outdated
@@ -171,3 +171,27 @@ podman push ${REGISTRY}/origin-node:latest
```
echo "NODE_IMAGE=${REGISTRY}/origin-node:latest" >> ${CLUSTER_DIR}/env.sh
```

# OVN - Change Geneve Port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to document this here; it will eventually be in the full OpenShift documentation

Copy link
Contributor Author

@pecameron pecameron Oct 8, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can document it here as a convenience to developers and information for the doc team. Eventually can be a long time and its not always obvious where to look.

README.md Outdated Show resolved Hide resolved
pkg/network/ovn_kubernetes.go Outdated Show resolved Hide resolved
pkg/network/ovn_kubernetes.go Show resolved Hide resolved
pkg/network/ovn_kubernetes_test.go Outdated Show resolved Hide resolved
sample-ovn-config.yaml Outdated
hostPrefix: 23
defaultNetwork:
type: OVNKubernetes
RovnKubernetesConfig:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. also, we still don't need this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo. It was not obvious how to code this.

@pecameron pecameron force-pushed the sdn494 branch 2 times, most recently from 088c93c to bc03346 Compare October 9, 2019 15:08
@pecameron
Copy link
Contributor Author

@danwinship @squeed PTAL

@pecameron
Copy link
Contributor Author

/retest

@pecameron
Copy link
Contributor Author

/hold
waiting for PR 333 to land and configmap to be updated.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2019
@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn-kubernetes

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2020
@pecameron
Copy link
Contributor Author

pecameron commented Jan 2, 2020 •
edited

PR 333 is merged so remove the hold
/hold cancel
/test e2e-aws-ovn-kubernetes

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@pecameron
ovn custom geneve port number
f1b6046 
SDN-494 - ovn custom geneve port number.
https://jira.coreos.com/browse/SDN-494

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2020
@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn-kubernetes

@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn-kubernetes

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2020 •
edited

@pecameron: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 4d791de link /test e2e-aws
ci/prow/e2e-aws-ovn-kubernetes 8d07b3e link /test e2e-aws-ovn-kubernetes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pecameron
Copy link
Contributor Author

/retest

@pecameron
Copy link
Contributor Author

@knobunc @JacobTanenbaum PTAL
I addressed danwinship's comments.

knobunc
knobunc approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 501fa97 into openshift:master Jan 3, 2020
@pecameron pecameron deleted the sdn494 branch January 3, 2020 14:55
@danwinship danwinship mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship requested changes

@dcbw dcbw dcbw left review comments

@knobunc knobunc knobunc approved these changes

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pecameron @openshift-ci-robot @danwinship @knobunc @dcbw @openshift-merge-robot