Bug 1761609: Remove SDN ds liveness check

[rcarrillocruz]

Fixes BZ 1761609

[openshift-ci-robot]

@rcarrillocruz: This pull request references Bugzilla bug 1761609, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1761609: Remove SDN ds liveness check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhat]

@squeed do you think this should be removed altogether or we should just tweak around the probe parameters at scale to account for slower response times?

[danwinship]

The problem (IIRC) is that the kube-proxy liveness server doesn't get started until after the sdn "node" stuff is fully started up, so in large clusters where startup takes longer, the kubelet may time out on the liveness check before it's even running. So the fix, if we want to keep the liveness check, is to rearrange sdn startup. But I think there was some feeling that the liveness check isn't really super helpful anyway...

[squeed]

Right.
At this point, we've not seen the liveness check detect any sort of liveness failure.. Especially troublesome is that if we take a long time to fill our informer caches (because of slow apiserver or big cluster), the liveness check will shoot us in the head. I know that I had assumed the liveness would hold off until the pod entered Ready state. Nope.

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rcarrillocruz, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [squeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rcarrillocruz: All pull requests linked via external trackers have merged. Bugzilla bug 1761609 has been moved to the MODIFIED state.

In response to this:

Bug 1761609: Remove SDN ds liveness check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.