Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OVN - fix cluster role binding #412

Merged
merged 1 commit into from Dec 4, 2019
Merged

OVN - fix cluster role binding #412

merged 1 commit into from Dec 4, 2019

Conversation

pecameron
Copy link
Contributor

Signed-off-by: Phil Cameron pcameron@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2019
@pecameron
Copy link
Contributor Author

@dcbw @danwinship PTAL

@squeed
Copy link
Contributor

squeed commented Dec 3, 2019

omg
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@squeed
Copy link
Contributor

squeed commented Dec 3, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@dcbw
Copy link
Contributor

dcbw commented Dec 3, 2019

/hold

hang on a sec, openshift-sdn doesn't do this, so it may not actually be required...

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2019
@pecameron
Copy link
Contributor Author

@dcbw @squeed PTAL

@pecameron
Copy link
Contributor Author

/test aws-e2e-ovn

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2019
@pecameron
Copy link
Contributor Author

Some changes dcbw suggested.
@dcbw @squeed PTAL

@pecameron
OVN - fix cluster role binding
1e843cb 
Signed-off-by: Phil Cameron <pcameron@redhat.com>
@dcbw
Copy link
Contributor

dcbw commented Dec 3, 2019

/test aws-e2e-ovn

@dcbw
Copy link
Contributor

dcbw commented Dec 3, 2019

/test e2e-aws-ovn

@dcbw
Copy link
Contributor

dcbw commented Dec 4, 2019

/hold cancel
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pecameron, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e3a6f1e into openshift:master Dec 4, 2019
@openshift-ci-robot
Copy link
Contributor

@pecameron: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ovn 1e843cb link /test e2e-aws-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pecameron pecameron deleted the sdn637c branch December 6, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@squeed squeed

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pecameron @squeed @dcbw @openshift-ci-robot @openshift-bot @openshift-merge-robot