osdn, ovnk: add publishNotReadyAddresses to metrics services #427
Conversation
Since these services are just used to configure Prometheus scrape targets, rather than load-balance traffic, we should not remove not-ready addresses from them.
|
/test e2e-aws-ovn |
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
\lgtm |
|
makes sense |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
More or less, yeah. Good point, I'll update. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since these services are just used to configure Prometheus scrape targets, rather than load-balance traffic, we should not remove not-ready addresses from them.