New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding run-remotely.sh script #441
Adding run-remotely.sh script #441
Conversation
That's what |
FWIW, PLUGIN_IMAGE is for if you have a custom ovnkube or SDN docker image that you want to run in the cluster to test changes. It's less useful now that we have infrastructure for running CI with ovnkube (which we didn't have at the time). But perhaps still useful. |
375bbf6
to
0f96480
Compare
/test e2e-gcp-upgrade |
/test e2e-gcp |
1 similar comment
/test e2e-gcp |
/test e2e-gcp flake, flake, flake....man, what is it snowing?! |
/test e2e-gcp |
0f96480
to
03fba26
Compare
/assign @danwinship |
hack/run-locally.sh
Outdated
@@ -239,7 +254,13 @@ echo "rebuilding the CNO" | |||
hack/build-go.sh | |||
|
|||
# Autodetect the state of the cluster to determine which mode to run in | |||
if [[ -z "$(ls -A ${CLUSTER_DIR} 2> /dev/null | grep -v install-config.yaml | grep -v .openshift_install | grep -v env.sh)" ]]; then | |||
if [[ ! -z "${KUBECONFIG}" ]]; then | |||
export CLUSTER_DIR=$PWD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... what does this end up getting used for? Would it be better to use a temporary directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used for the ${CLUSTER_DIR}/env.sh
which contains the image overrides. I could use a temporary directory. Would /tmp/env.sh
be fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use mktemp -d
.
Alternatively, write the environment to ${KUBECONFIG}.cno-env.sh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used mktemp -d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acutally, I've been re-thinking this. Usually what we want is also to just create a env.sh
and modify the image targeted, then re-deploy.
I thus think it would be easier if we just use CLUSTER_DIR=/tmp
if we only have a $KUBECONFIG
. Then modify the /tmp/env.sh
and re-deploy. I think it's easier as such.
03fba26
to
d514d50
Compare
d514d50
to
8539b5d
Compare
82993d6
to
05ceffc
Compare
/test e2e-gcp-upgrade |
/test e2e-gcp |
@danwinship Could you have a final look at this?Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@alexanderConstantinescu: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@alexanderConstantinescu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR introduces a
run-remotely.sh
script which allows us to run the CNO against a remotely running cluster. It's based off ofrun-locally.sh
and takes only a kubeconfig argument. It strips off some of the logic surrounding manifests, install-config, etc that therun-locally.sh
script has.I am not familiar with the reasons behind having the
PLUGIN_IMAGE
variable. But I kept it, in case someone was using it to modify theenv.sh
using that mechanism.