Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1791277: Stop deploying kuryr-admission-controller if double listeners supported #444

Merged
merged 1 commit into from Jan 16, 2020
Merged

Bug 1791277: Stop deploying kuryr-admission-controller if double listeners supported #444

merged 1 commit into from Jan 16, 2020

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Jan 13, 2020

If octavia amphora provider supports double listeners, i.e.,
exposing the same port but on different protocol (e.g., udp and tcp)
then there is no need for deploying the kuryr-admission-controller
to enforce dns resolution over TCP, as we can create both udp and
tcp listeners on port 53 for the DNS service

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2020
@luis5tb luis5tb changed the title Stop deploying kuryr-admission-controller if double listeners supported WIP Stop deploying kuryr-admission-controller if double listeners supported Jan 13, 2020
@gryf
Copy link
Member

gryf commented Jan 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
dulek
dulek suggested changes Jan 14, 2020
View reviewed changes
pkg/bootstrap/types.go Outdated
@@ -13,6 +13,7 @@ type KuryrBootstrapResult struct {
ExternalNetwork string
ClusterID string
OctaviaProvider string
OctaviaDL bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's effectively double listeners at the moment, I'd rather use multiple listeners. And probably it's worth to be explicit, golang doesn't have limit on line length, so "OctaviaMultipleListeners" is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I'll modify it

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@luis5tb
Stop deploying kuryr-admission-controller if double listeners supported
c0a01d0 
If octavia amphora provider supports double listeners, i.e.,
exposing the same port but on different protocol (e.g., udp and tcp)
then there is no need for deploying the kuryr-admission-controller
to enforce dns resolution over TCP, as we can create both udp and
tcp listeners on port 53 for the DNS service
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 14, 2020

/test e2e-gcp

1 similar comment
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 14, 2020

/test e2e-gcp

@luis5tb luis5tb changed the title WIP Stop deploying kuryr-admission-controller if double listeners supported Stop deploying kuryr-admission-controller if double listeners supported Jan 15, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 15, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 15, 2020

holding it until kuryr-kubernetes adds the support for it

@luis5tb luis5tb changed the title Stop deploying kuryr-admission-controller if double listeners supported Bug 1791277: Stop deploying kuryr-admission-controller if double listeners supported Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: This pull request references Bugzilla bug 1791277, which is valid. The bug has been moved to the POST state.

In response to this:

Bug 1791277: Stop deploying kuryr-admission-controller if double listeners supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gryf
Copy link
Member

gryf commented Jan 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 16, 2020

/approve

@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 16, 2020

/assign @dcbw

@dulek
Copy link
Contributor

dulek commented Jan 16, 2020

/lgtm

@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 16, 2020

/assign @danwinship

@danwinship
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dulek, gryf, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cee4cf9 into openshift:master Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: All pull requests linked via external trackers have merged. Bugzilla bug 1791277 has been moved to the MODIFIED state.

In response to this:

Bug 1791277: Stop deploying kuryr-admission-controller if double listeners supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 16, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

@luis5tb: #444 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/bootstrap/types.go
M	pkg/network/kuryr.go
M	pkg/platform/openstack/kuryr_bootstrap.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/platform/openstack/kuryr_bootstrap.go
CONFLICT (content): Merge conflict in pkg/platform/openstack/kuryr_bootstrap.go
Auto-merging pkg/network/kuryr.go
CONFLICT (content): Merge conflict in pkg/network/kuryr.go
Auto-merging pkg/bootstrap/types.go
CONFLICT (content): Merge conflict in pkg/bootstrap/types.go
Patch failed at 0001 Stop deploying kuryr-admission-controller if double listeners supported

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb luis5tb mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek requested changes

@celebdor celebdor Awaiting requested review from celebdor

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@danwinship danwinship

@dulek dulek

@gryf gryf

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@luis5tb @gryf @openshift-ci-robot @dulek @danwinship @openshift-bot @openshift-cherrypick-robot @dcbw @openshift-merge-robot