Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kuryr K8s resources to latest versions #455

Merged
merged 1 commit into from Mar 4, 2020
Merged

Update Kuryr K8s resources to latest versions #455

merged 1 commit into from Mar 4, 2020

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Jan 23, 2020

Webhooks and CRDs got out of beta with K8s 1.16. This commit updates
Kuryr resources to use the new v1 versions of them.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@dulek dulek requested a review from luis5tb January 23, 2020 10:58
@dulek
Copy link
Contributor Author

dulek commented Jan 23, 2020

/hold

Seems like those would not really validate for some reason?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@dulek
Copy link
Contributor Author

dulek commented Jan 23, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@dulek
Copy link
Contributor Author

dulek commented Jan 23, 2020

/hold

Still some issues, it seems.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@dulek
Copy link
Contributor Author

dulek commented Feb 28, 2020

/hold cancel

Okay, this version should be fine.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@dulek
Copy link
Contributor Author

dulek commented Mar 2, 2020

/retest

2 similar comments
@dulek
Copy link
Contributor Author

dulek commented Mar 2, 2020

/retest

@dulek
Copy link
Contributor Author

dulek commented Mar 3, 2020

/retest

@dulek
Copy link
Contributor Author

dulek commented Mar 3, 2020

/hold

Whoops, one mistake…?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@dulek dulek force-pushed the kuryr-update-crd-webhooks branch from b2ba397 to efeda90 Compare March 3, 2020 16:02
@dulek
Copy link
Contributor Author

dulek commented Mar 3, 2020

/hold cancel

Okay, it should be fine now.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@dulek
Copy link
Contributor Author

dulek commented Mar 3, 2020

/retest

Seems pretty unrelated, though also completely broken.

@dulek
Update Kuryr K8s resources to latest versions
47a680c 
Webhooks and CRDs got out of beta with K8s 1.16. This commit updates
Kuryr resources to use the new v1 versions of them.
@dulek dulek force-pushed the kuryr-update-crd-webhooks branch from efeda90 to 47a680c Compare March 3, 2020 16:35
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

4 similar comments
@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dulek
Copy link
Contributor Author

dulek commented Mar 4, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fbd56ba into openshift:master Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

@dulek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 47a680c link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis5tb luis5tb luis5tb left review comments

@celebdor celebdor Awaiting requested review from celebdor

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dulek @MaysaMacedo @openshift-ci-robot @openshift-bot @luis5tb @openshift-merge-robot