Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kuryr: Handle unexpected errors fetching CA cert #462

Merged
merged 1 commit into from Feb 21, 2020
Merged

Kuryr: Handle unexpected errors fetching CA cert #462

merged 1 commit into from Feb 21, 2020

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Jan 31, 2020

Other implementations of OpenStack cloudprovider CA certs handling print
errors other than NotFound when fetching the CA cert ConfigMap. This
commit makes sure CNO follows the same pattern.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@dulek
Copy link
Contributor Author

dulek commented Jan 31, 2020

I'm not sure if this is still allowed to get into 4.4, it's technically not a bugfix.

@dulek
Copy link
Contributor Author

dulek commented Jan 31, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Feb 3, 2020

Seems like it may need a bugzilla associated to it

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@dulek
Kuryr: Handle unexpected errors fetching ConfigMaps
f029068 
Other implementations of OpenStack cloudprovider CA certs handling print
errors other than NotFound when fetching the CA cert ConfigMap. This
commit makes sure CNO follows the same pattern.

Also fetching kuryr-config ConfigMap is updated to raise unexpected
errors.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2020
@dulek
Copy link
Contributor Author

dulek commented Feb 20, 2020

/retest

1 similar comment
@dulek
Copy link
Contributor Author

dulek commented Feb 20, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@dulek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn f029068 link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gryf
Copy link
Member

gryf commented Feb 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, gryf, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit abb7388 into openshift:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@luis5tb luis5tb Awaiting requested review from luis5tb

@gryf gryf Awaiting requested review from gryf

@celebdor celebdor Awaiting requested review from celebdor

Assignees

@gryf gryf

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dulek @luis5tb @openshift-ci-robot @gryf @openshift-merge-robot