New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for ovn2.11 #467
Conversation
/test e2e-aws-ovn |
/retest |
APPCTL_PATH=/usr/bin/ovs-appctl | ||
fi | ||
exec ${APPCTL_PATH} -t ${DB_SOCK_PATH} cluster/status OVN_Northbound 2>/dev/null | grep ${K8S_NODE_IP} | grep -v Address -q | ||
exec /usr/bin/ovn-appctl -t /var/run/ovn/ovnnb_db.ctl ovsdb-server/sync-status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're reverting back to the older healthcheck command here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
APPCTL_PATH=/usr/bin/ovs-appctl | ||
fi | ||
exec ${APPCTL_PATH} -t ${DB_SOCK_PATH} cluster/status OVN_Southbound 2>/dev/null | grep ${K8S_NODE_IP} | grep -v Address -q | ||
exec /usr/bin/ovn-appctl -t /var/run/ovn/ovnsb_db.ctl ovsdb-server/sync-status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/retest |
Completes the switch from ovn2.11 to ovn2.12 by removing support for the now obsolete ovn2.11 SDN-643 https://issues.redhat.com/browse/SDN-643 Signed-off-by: Phil Cameron <pcameron@redhat.com>
@danwinship Made the changes. Anything else to address? PTAL |
/retest |
1 similar comment
/retest |
/lgtm |
@danwinship If there are not more changes could you drop the "change requested"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oops, yes, though FTR the bots don't actually care about that)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pecameron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@pecameron: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Completes the switch from ovn2.11 to ovn2.12 by removing support for the
now obsolete ovn2.11
SDN-643
https://issues.redhat.com/browse/SDN-643
Signed-off-by: Phil Cameron pcameron@redhat.com