Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1800633: Ensure etcd and authentication operator resolves dns over TCP #468

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Feb 10, 2020

The etcd and authentication operators pods might start before the Kuryr admission
controller is running, resulting in no dnsConfig option injected
on the pod spec to allow DNS resolution over TCP, and consequently
failure on DNS resolution.
This commit ensures the pods will have the option in place.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2020
@MaysaMacedo MaysaMacedo force-pushed the ensure-etcd-operator-dns-config branch from 6c89c68 to e63b065 Compare February 10, 2020 14:34
@MaysaMacedo
Copy link
Contributor Author

/assign @dulek

@MaysaMacedo MaysaMacedo changed the title Ensure etcd operator resolves dns over TCP Bug 1800633: Ensure etcd operator resolves dns over TCP Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1800633, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1800633: Ensure etcd operator resolves dns over TCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1800633, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Feb 10, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2020
@MaysaMacedo
Copy link
Contributor Author

/hold seems the authentication operator also needs config.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2020
The etcd and authentication operator pod might start before
the Kuryr admission controller is running, resulting in no
dnsConfig option injected on the pod spec to allow DNS resolution
over TCP, and consequently failure on resolving the DNS.

This commit ensures the pods will have the option in place.

minor fix
@MaysaMacedo MaysaMacedo force-pushed the ensure-etcd-operator-dns-config branch from e63b065 to 06aca3e Compare February 10, 2020 16:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@dulek
Copy link
Contributor

dulek commented Feb 10, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 10, 2020
@MaysaMacedo MaysaMacedo changed the title Bug 1800633: Ensure etcd operator resolves dns over TCP Bug 1800633: Ensure etcd and authentication operator resolves dns over TCP Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1800633, which is valid.

In response to this:

Bug 1800633: Ensure etcd and authentication operator resolves dns over TCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 41288e6 into openshift:master Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: All pull requests linked via external trackers have merged. Bugzilla bug 1800633 has been moved to the MODIFIED state.

In response to this:

Bug 1800633: Ensure etcd and authentication operator resolves dns over TCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 06aca3e link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaysaMacedo MaysaMacedo deleted the ensure-etcd-operator-dns-config branch February 11, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants