Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1804734: Kuryr: Disable multiple listeners for OVN provider #486

Merged

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Feb 19, 2020

Patch making sure Kuryr is not getting a sudden reconfiguration when
underlying Octavia is getting upgraded to version supporting OVN
provider broke the detection of support for multiple listeners. When
OVN provider is used, multiple listeners are not supported.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2020
@dulek dulek changed the title Kuryr: Disable multiple listeners for OVN provider Bug 1804734: Kuryr: Disable multiple listeners for OVN provider Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Bugzilla bug 1804734, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804734: Kuryr: Disable multiple listeners for OVN provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2020
@dulek
Copy link
Contributor Author

dulek commented Feb 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Bugzilla bug 1804734, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Patch making sure Kuryr is not getting a sudden reconfiguration when
underlying Octavia is getting upgraded to version supporting OVN
provider broke the detection of support for multiple listeners. When
OVN provider is used, multiple listeners are not supported.
@luis5tb
Copy link
Contributor

luis5tb commented Feb 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Feb 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d9b7e3b into openshift:master Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@dulek: All pull requests linked via external trackers have merged. Bugzilla bug 1804734 has been moved to the MODIFIED state.

In response to this:

Bug 1804734: Kuryr: Disable multiple listeners for OVN provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@dulek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 01f0eae link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luis5tb
Copy link
Contributor

luis5tb commented Feb 19, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@luis5tb: new pull request created: #488

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants