Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1789881: Start ovn correctly with hybrid networking #500

Merged
merged 1 commit into from Mar 4, 2020
Merged

Bug 1789881: Start ovn correctly with hybrid networking #500

merged 1 commit into from Mar 4, 2020

Conversation

JacobTanenbaum
Copy link
Contributor

Tell ovn to not assign hostsubnets to nodes labeled

kubernetes.io/os=windows

when enabeling hybrid networking. This ensures correct operation as the
node deals with it's own hostsubnet

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1789881

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2020
@sdodson
Copy link
Member

sdodson commented Feb 25, 2020

/retitle Bug 1789881: Start ovn correctly with hybrid networking

@openshift-ci-robot openshift-ci-robot changed the title Start ovn correctly with hybrid networking Bug 1789881: Start ovn correctly with hybrid networking Feb 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Bugzilla bug 1789881, which is valid.

In response to this:

Bug 1789881: Start ovn correctly with hybrid networking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Start ovn correctly with hybrid networking
77f7e60 
Tell ovn to not assign hostsubnets to nodes labeled

kubernetes.io/os=windows

when enabeling hybrid networking. This ensures correct operation as the
node deals with it's own hostsubnets
@dcbw
Copy link
Member

dcbw commented Mar 3, 2020

/retest

1 similar comment
@dcbw
Copy link
Member

dcbw commented Mar 3, 2020

/retest

@dcbw
Copy link
Member

dcbw commented Mar 4, 2020

Sigh.

/bin/bash: line 174:   208 Killed                  openshift-tests run "${TEST_SUITE}" --provider "${TEST_PROVIDER:-}" -o /tmp/artifacts/e2e.log --junit-dir /tmp/artifacts/junit
2020/03/04 00:45:55 Container test in pod e2e-gcp-ovn failed, exit code 137, reason OOMKilled

/retest

@dcbw
Copy link
Member

dcbw commented Mar 4, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2e892e2 into openshift:master Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 77f7e60 link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pecameron pecameron mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw dcbw left review comments

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JacobTanenbaum @sdodson @openshift-ci-robot @dcbw @openshift-bot @openshift-merge-robot