Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1807611: Set network config status even with unknown network plugin #506

Merged

Commits on Feb 27, 2020

  1. Set network config status even with unknown network plugin

    Some components depend on some fields of configv1.NetworkStatus. Eg,
    cluster-kubernetes-apiserver-operator needs to know the
    ServiceNetwork.
    
    Previously we weren't setting the status when the default network type
    was unknown, because we didn't know that the external network plugin
    would consider them valid. (eg, there might be multiple ClusterNetwork
    values but the plugin only supports one.) But this breaks components
    that assume they can get their config from there.
    
    Fix this by setting the status fields but allowing them to be
    overridden by another operator if the network type is unknown.
    danwinship committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    2928738 View commit details
    Browse the repository at this point in the history